public inbox for dtrace@lists.linux.dev
 help / color / mirror / Atom feed
* [PATCH] test: Increase syscall entry timeout
@ 2026-01-22 22:01 eugene.loh
  2026-01-27 12:56 ` [DTrace-devel] " Nick Alcock
  0 siblings, 1 reply; 2+ messages in thread
From: eugene.loh @ 2026-01-22 22:01 UTC (permalink / raw)
  To: dtrace, dtrace-devel

From: Eugene Loh <eugene.loh@oracle.com>

The run time for this test seems twice as long for aarch64 as for
x86_64.  Further, the run time seems to have jumped significantly from
kernel 5.15 to 6.12 and then again to kernel 6.18.  E.g.,

                  x86_64     aarch64
    5.15          7 secs     18 secs
    6.12         12 secs     33 secs
    6.18         22 secs     54 secs

Looking at a run on the 6.18 aarch64 system, the time is basically
spent in the dtrace_close() call to dt_probe_detach_all(), which does:

    for (prp = ...)
        prp->prov->impl->detach(dtp, prp);

Then, dt_tp_probe_detach() calls dt_tp_detach(), which does:

    close(tpp->fd);

This close() averages over 0.1 secs.  For hundreds of syscall probes,
we get nearly a minute of run time, exceeding the default test timeout.

For the time being, increase the timeout on this test.

Signed-off-by: Eugene Loh <eugene.loh@oracle.com>
---
 test/unittest/syscall/tst.entry.d | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/test/unittest/syscall/tst.entry.d b/test/unittest/syscall/tst.entry.d
index f2d56150d..dfd7304e5 100644
--- a/test/unittest/syscall/tst.entry.d
+++ b/test/unittest/syscall/tst.entry.d
@@ -1,6 +1,6 @@
 /*
  * Oracle Linux DTrace.
- * Copyright (c) 2020, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2020, 2026, Oracle and/or its affiliates. All rights reserved.
  * Licensed under the Universal Permissive License v 1.0 as shown at
  * http://oss.oracle.com/licenses/upl.
  */
@@ -8,6 +8,7 @@
 /* @@trigger: syscall-tst-args */
 /* @@trigger-timing: before */
 /* @@runtest-opts: $_pid */
+/* @@timeout: 80 */
 
 /* check that syscall:::entry picks up mmap:entry */
 /* (mmap is called repeatedly by the trigger) */
-- 
2.47.3


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [DTrace-devel] [PATCH] test: Increase syscall entry timeout
  2026-01-22 22:01 [PATCH] test: Increase syscall entry timeout eugene.loh
@ 2026-01-27 12:56 ` Nick Alcock
  0 siblings, 0 replies; 2+ messages in thread
From: Nick Alcock @ 2026-01-27 12:56 UTC (permalink / raw)
  To: eugene.loh--- via DTrace-devel; +Cc: dtrace, eugene.loh

On 22 Jan 2026, eugene loh outgrape:

> From: Eugene Loh <eugene.loh@oracle.com>
>
> The run time for this test seems twice as long for aarch64 as for
> x86_64.  Further, the run time seems to have jumped significantly from
> kernel 5.15 to 6.12 and then again to kernel 6.18.  E.g.,

Ew.

>                   x86_64     aarch64
>     5.15          7 secs     18 secs
>     6.12         12 secs     33 secs
>     6.18         22 secs     54 secs
>
> Looking at a run on the 6.18 aarch64 system, the time is basically
> spent in the dtrace_close() call to dt_probe_detach_all(), which does:
>
>     for (prp = ...)
>         prp->prov->impl->detach(dtp, prp);
>
> Then, dt_tp_probe_detach() calls dt_tp_detach(), which does:
>
>     close(tpp->fd);
>
> This close() averages over 0.1 secs.  For hundreds of syscall probes,
> we get nearly a minute of run time, exceeding the default test timeout.

Sounds like another O(n^2) crept back in somewhere in the kernel :(

> For the time being, increase the timeout on this test.
>
> Signed-off-by: Eugene Loh <eugene.loh@oracle.com>

Reviewed-by: Nick Alcock <nick.alcock@oracle.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-01-27 12:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-22 22:01 [PATCH] test: Increase syscall entry timeout eugene.loh
2026-01-27 12:56 ` [DTrace-devel] " Nick Alcock

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox