Re: [PATCH] cg: fix offset for > 8 bit bitfields in dt_cg_ctf_offsetof()

Alan Maguire
2025-09-03T14:11:52Z

On 02/09/2025 19:05, Eugene Loh wrote:
> So far as I can tell:
>
> *) https://oss.oracle.com/pipermail/dtrace-devel/2025-August/006562.html
>     Nick commented on the patch
>
> *) https://oss.oracle.com/pipermail/dtrace-devel/2025-August/006573.html
>     Alan responded to Nick
>
> Since this patch is related to observed test failures, can we complete
> this patch review?  E.g., perhaps Nick can respond to Alan's last
> message, maybe even agreeing with Alan's proposal simply to add a
> comment that we don't need bitshifts yet.  If so, Alan can post a v2 of
> the patch and then Nick or I could add our "Reviewed-by"?
>

sounds good to me; if Nick is happy with that plan I'll send v2 ASAP.

Thanks!

Alan