From: Nick Alcock <nix@esperi.org.uk>
To: Kris Van Hees <kris.van.hees@oracle.com>
Cc: dtrace@lists.linux.dev, dtrace-devel@oss.oracle.com
Subject: Re: [PATCH 15/20] libdtrace: search both ELF symbol tables for module symbols
Date: Fri, 06 Nov 2026 13:13:40 +0000 [thread overview]
Message-ID: <87ik2artkr.fsf@esperi.org.uk> (raw)
In-Reply-To: <9a3ef30ca35af2d994b6f8a42a8e6700@oracle.com>
On 30 Oct 2026, Kris Van Hees said:
> Keep independent symbol and address indices for SHT_SYMTAB and SHT_DYNSYM,
> loading strings through each table’s sh_link. Search .symtab before .dynsym
> and include dynamic-only names in module symbol iteration.
Yet noather place where one or the other strtab was overlooked. These
mistakes all date right back to Solaris...
> Preserve .symtab indices for CTF, place dynamic and external symbols in
> separate ID ranges, and use .dynsym for CTF when .symtab is absent. Allow
Except in old dicts (CTFv2, or v3 in the absence of the CTF_F_DYNSTR
dict flag), .dynsym should be searched unconditionally for CTF.
Preferring the symtab is wrong. (I suspect this code is basically never
run, since it's all symtypetab stuff, and the symtypetab isn't emitted
for kernel CTF.)
--
NULL && (void)
next prev parent reply other threads:[~2026-11-06 13:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-30 19:36 [PATCH 15/20] libdtrace: search both ELF symbol tables for module symbols Kris Van Hees
2026-11-06 13:13 ` Nick Alcock [this message]
2026-11-06 13:16 ` Nick Alcock
2026-11-06 21:29 ` Kris Van Hees
2026-11-06 21:27 ` Kris Van Hees
2026-11-07 16:04 ` Kris Van Hees
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ik2artkr.fsf@esperi.org.uk \
--to=nix@esperi.org.uk \
--cc=dtrace-devel@oss.oracle.com \
--cc=dtrace@lists.linux.dev \
--cc=kris.van.hees@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox