From: Nick Alcock <nick.alcock@oracle.com>
To: eugene.loh@oracle.com
Cc: dtrace@lists.linux.dev, dtrace-devel@oss.oracle.com
Subject: Re: [PATCH] Make sure all probes are listed in default case
Date: Tue, 22 Jul 2025 15:19:59 +0100 [thread overview]
Message-ID: <87o6tc71f4.fsf@esperi.org.uk> (raw)
In-Reply-To: <20250628011932.23469-1-eugene.loh@oracle.com> (eugene loh's message of "Fri, 27 Jun 2025 21:19:32 -0400")
On 28 Jun 2025, eugene loh spake thusly:
> From: Eugene Loh <eugene.loh@oracle.com>
>
> Signed-off-by: Eugene Loh <eugene.loh@oracle.com>
Reviewed-by: Nick Alcock <nick.alcock@oracle.com>
(presumably this is fixing the problem that lazily-instantiated probes
like fbt now is weren't instantiating probes before trying to list
them.)
I winced at this at first:
> + # Recognize some providers; apply sanity check on number of probes.
> + $2 == "cpc" { mycheck($2, $1, 5, 500); next }
> + $2 == "dtrace" { mycheck($2, $1, 3, 3); next }
> + $2 == "fbt" { mycheck($2, $1, 30000, 300000); next }
> + $2 == "io" { mycheck($2, $1, 2, 20); next }
> + $2 == "ip" { mycheck($2, $1, 2, 20); next }
> + $2 == "lockstat" { mycheck($2, $1, 4, 40); next }
> + # nothing for pid
> + $2 == "proc" { mycheck($2, $1, 6, 30); next }
> + $2 == "profile" { mycheck($2, $1, 6, 30); next }
> + $2 == "rawfbt" { mycheck($2, $1, 30000, 300000); next }
> + $2 == "rawtp" { mycheck($2, $1, 600, 6000); next }
> + $2 == "sched" { mycheck($2, $1, 3, 30); next }
> + $2 == "sdt" { mycheck($2, $1, 600, 6000); next }
> + $2 == "syscall" { mycheck($2, $1, 300, 3000); next }
> + # nothing for usdt
... but honestly if the figures are outside those bounds something is
*definitely* wrong (and it'll be obvious when they really need
updating).
--
NULL && (void)
next prev parent reply other threads:[~2025-07-22 14:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-28 1:19 [PATCH] Make sure all probes are listed in default case eugene.loh
2025-07-22 14:19 ` Nick Alcock [this message]
2025-07-22 14:52 ` Eugene Loh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o6tc71f4.fsf@esperi.org.uk \
--to=nick.alcock@oracle.com \
--cc=dtrace-devel@oss.oracle.com \
--cc=dtrace@lists.linux.dev \
--cc=eugene.loh@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox