[PATCH 3/3] dtprobed: fix install of dtprobed.service

[PATCH 3/3] dtprobed: fix install of dtprobed.service

[Kris Van Hees]

Commit 4d4ba4997 "build: make dtrace and dtprobed relocatable" added
makefile instructions to install dtprobed.service that could fail due
to permission problems.  Instead of using sed to write to the install
location, and then applying chown/chmod, use the install command.

Signed-off-by: Kris Van Hees <kris.van.hees@oracle.com>
---
 dtprobed/Build | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/dtprobed/Build b/dtprobed/Build
index c43b6277..8619a5b5 100644
--- a/dtprobed/Build
+++ b/dtprobed/Build
@@ -41,9 +41,8 @@ install-dtprobed-autostart::
 ifneq ($(WITH_SYSTEMD),)
 	mkdir -p $(INSTSYSTEMDUNITDIR) $(INSTSYSTEMDPRESETDIR)
 	$(call describe-install-target,$(INSTSYSTEMDUNITDIR),dtprobed.service)
-	sed 's,@SBINDIR@,$(SBINDIR),' < $(dtprobed_DIR)dtprobed.service.in > $(INSTSYSTEMDUNITDIR)/dtprobed.service
-        chown root:root $(INSTSYSTEMDUNITDIR)/dtprobed.service
-	chmod 0644 $(INSTSYSTEMDUNITDIR)/dtprobed.service
+	sed 's,@SBINDIR@,$(SBINDIR),' < $(dtprobed_DIR)dtprobed.service.in > $(objdir)/dtprobed.service
+	install -m 644 $(objdir)/dtprobed.service $(INSTSYSTEMDUNITDIR)
 	$(call describe-install-target,$(INSTSYSTEMDUNITDIR),dtrace-usdt.target)
 	install -m 644 $(dtprobed_DIR)dtrace-usdt.target $(INSTSYSTEMDUNITDIR)
 	$(call describe-install-target,$(INSTSYSTEMDPRESETDIR),50-dtprobed.preset)
-- 
2.42.0

Re: [PATCH 3/3] dtprobed: fix install of dtprobed.service

[Nick Alcock]

On 11 Nov 2024, Kris Van Hees said:

> Commit 4d4ba4997 "build: make dtrace and dtprobed relocatable" added
> makefile instructions to install dtprobed.service that could fail due
> to permission problems.  Instead of using sed to write to the install
> location, and then applying chown/chmod, use the install command.
>
> Signed-off-by: Kris Van Hees <kris.van.hees@oracle.com>

Reviewed-by: Nick Alcock <nick.alcock@oracle.com>

(better than what I did.)

-- 
NULL && (void)