public inbox for dtrace@lists.linux.dev
 help / color / mirror / Atom feed
* [PATCH 0/1] Fix doc directory cleanup
@ 2025-09-12 21:56 Elena Zannoni
  2025-09-12 21:56 ` [PATCH 1/1] Make sure the doc dir is cleaned up on RPM uninstall Elena Zannoni
  0 siblings, 1 reply; 3+ messages in thread
From: Elena Zannoni @ 2025-09-12 21:56 UTC (permalink / raw)
  To: dtrace-devel, dtrace

Currently, uninstalling the dtrace RPM leaves an 
empty doc directory behind. Such as:

$ ls /usr/share/doc/dtrace-2.0.3/
INCOMPATIBILITIES  NEWS  README  showUSDT
$ sudo rpm -e dtrace-2.0.3
Removed '/etc/systemd/system/basic.target.wants/dtprobed.service'.
Removed '/etc/systemd/system/basic.target.wants/dtrace-usdt.target'.
$ ls /usr/share/doc/dtrace-2.0.3/
$

This patch changes the list of files to include the directory
itself, not just its contents.

After this patch the behavior is:

$ ls /usr/share/doc/dtrace-2.0.3/
INCOMPATIBILITIES  NEWS  README  showUSDT
$ sudo rpm -e dtrace-2.0.3
Removed '/etc/systemd/system/basic.target.wants/dtprobed.service'.
Removed '/etc/systemd/system/basic.target.wants/dtrace-usdt.target'.
$ ls /usr/share/doc/dtrace-2.0.3/
ls: cannot access '/usr/share/doc/dtrace-2.0.3/': No such file or directory


Elena Zannoni (1):
  Make sure the doc dir is cleaned up on RPM uninstall

 dtrace.spec | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.49.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 1/1] Make sure the doc dir is cleaned up on RPM uninstall
  2025-09-12 21:56 [PATCH 0/1] Fix doc directory cleanup Elena Zannoni
@ 2025-09-12 21:56 ` Elena Zannoni
  2025-09-14 12:27   ` Nick Alcock
  0 siblings, 1 reply; 3+ messages in thread
From: Elena Zannoni @ 2025-09-12 21:56 UTC (permalink / raw)
  To: dtrace-devel, dtrace

 Add to the RPM file list the entire dtrace doc directory,
 not just its contents

Signed-off-by: Elena Zannoni <elena.zannoni@oracle.com>
---
 dtrace.spec | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dtrace.spec b/dtrace.spec
index 115cea60..a325993a 100644
--- a/dtrace.spec
+++ b/dtrace.spec
@@ -211,7 +211,7 @@ systemctl start dtprobed || :
 %{_datadir}/pkgconfig/dtrace_sdt.pc
 %{_mandir}/man8/dtrace.8.gz
 %{_mandir}/man8/dtprobed.8.gz
-%doc %{_docdir}/dtrace-%{version}/*
+%doc %{_docdir}/dtrace-%{version}
 %{_unitdir}/dtprobed.service
 %{_unitdir}/dtrace-usdt.target
 %{_presetdir}/50-dtprobed.preset
-- 
2.49.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] Make sure the doc dir is cleaned up on RPM uninstall
  2025-09-12 21:56 ` [PATCH 1/1] Make sure the doc dir is cleaned up on RPM uninstall Elena Zannoni
@ 2025-09-14 12:27   ` Nick Alcock
  0 siblings, 0 replies; 3+ messages in thread
From: Nick Alcock @ 2025-09-14 12:27 UTC (permalink / raw)
  To: Elena Zannoni; +Cc: dtrace-devel, dtrace

On 12 Sep 2025, Elena Zannoni told this:

>  Add to the RPM file list the entire dtrace doc directory,
>  not just its contents
>
> Signed-off-by: Elena Zannoni <elena.zannoni@oracle.com>

Reviewed-by: Nick Alcock <nick.alcock@oracle.com>

-- 
NULL && (void)

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-09-14 12:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-12 21:56 [PATCH 0/1] Fix doc directory cleanup Elena Zannoni
2025-09-12 21:56 ` [PATCH 1/1] Make sure the doc dir is cleaned up on RPM uninstall Elena Zannoni
2025-09-14 12:27   ` Nick Alcock

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox