Re: [PATCH 3/4] test: Update some char-array results files

Nick Alcock
2025-07-22T13:51:51Z

On 25 Mar 2025, eugene loh said:

> From: Eugene Loh <eugene.loh@oracle.com>
>
> A few tests started failing with commit 3a551bfd
> ("trace: fix char-array handling"). Update the results files to
> reflect older behavior, whether on Solaris or with the legacy
> Linux DTrace implementation.

I think this commit didn't get reviewed because nobody understood what
this meant. If tests started failing, why adjust the results to reflect
*older* behaviour (presumably "before that change"?)

Or do you mean that commit 3a551bfd adjusted trace() to work like it
historically did, but one test was missed and needs correspondingly
adjusting?

> Notice that test/unittest/funcs/substr/tst.substr-large-idx.d
> specifies strsize=256. The older behavior would result in 256
> chars being shown. We add a results file that includes a 257th
> char.

(the trailing NUL, presumably.)