From: Nick Alcock <nick.alcock@oracle.com>
To: Kris Van Hees <kris.van.hees@oracle.com>
Cc: dtrace@lists.linux.dev, dtrace-devel@oss.oracle.com, sam@gentoo.org
Subject: Re: [PATCH v2 01/14] No longer depend on libsystemd
Date: Tue, 29 Oct 2024 21:51:25 +0000 [thread overview]
Message-ID: <87ttcuo9wi.fsf@esperi.org.uk> (raw)
In-Reply-To: <ZyEpHYo6ZeuBaa4W@oracle.com> (Kris Van Hees's message of "Tue, 29 Oct 2024 14:27:41 -0400")
On 29 Oct 2024, Kris Van Hees told this:
> You are your own enemy :) Since you chose to use all spaces for indentation
> in your configure script, you now introduced inconsistency by adding lines
> with tabs! See below...
AUGH
Maybe I should just arrange for my emacs to just fight itself all day
long.
(Of course git log --check can't simultaneously diagnose this and the
opposite problem...)
> On Mon, Oct 28, 2024 at 09:17:50PM +0000, Nick Alcock wrote:
>> diff --git a/configure b/configure
>> index 4026a3eafcd3..72eb734a8380 100755
>> --- a/configure
>> +++ b/configure
>> @@ -93,9 +93,13 @@ built locally, none of these should be needed):
>>
>> EOF
>> make help-overrides-header help-overrides-option
>> + cat >&2 <<'EOF'
>
> Leading tab whereas all other lines use spaces.
An audit reveals several such lines, actually (not all introduced by
this patch, though most were). Fixed the lot because why not. This
means we have a few extra "spurious" whitespace changes in this patch
now, e.g.
- --prefix=*) write_make_var prefix "$option";;
+ --prefix=*) write_make_var prefix "$option";;
but only a very few.
--
NULL && (void)
next prev parent reply other threads:[~2024-10-29 21:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-28 21:17 [PATCH v2 00/14] gentoo, manpage, and assorted other small fixes Nick Alcock
2024-10-28 21:17 ` [PATCH v2 01/14] No longer depend on libsystemd Nick Alcock
2024-10-29 18:27 ` Kris Van Hees
2024-10-29 21:51 ` Nick Alcock [this message]
2024-10-28 21:17 ` [PATCH v2 02/14] pkgconfig: drop spaces in variable decls Nick Alcock
2024-10-28 21:17 ` [PATCH v2 03/14] configure, build: make valgrind optional Nick Alcock
2024-10-28 21:17 ` [PATCH v2 04/14] build: substitute LIBDIR in pkg-config files Nick Alcock
2024-10-28 21:17 ` [PATCH v2 05/14] probe: improve dt_probe_lookup2() Nick Alcock
2024-10-29 19:50 ` [DTrace-devel] " Kris Van Hees
2024-10-29 21:57 ` Nick Alcock
2024-10-28 21:17 ` [PATCH v2 06/14] configure: fix dreadful behaviour of MANDIR / --mandir Nick Alcock
2024-10-28 21:17 ` [PATCH v2 07/14] man: the synopsis is ended with .YS, not .SY Nick Alcock
2024-10-28 21:17 ` [PATCH v2 08/14] man: use \- for option dashes, not - Nick Alcock
2024-10-28 21:17 ` [PATCH v2 09/14] man: drop blank lines Nick Alcock
2024-10-28 21:17 ` [PATCH v2 10/14] man: fix blank line in environment variables list Nick Alcock
2024-10-28 21:18 ` [PATCH v2 11/14] dtprobed: fix parser child timeout Nick Alcock
2024-10-28 21:18 ` [PATCH v2 12/14] man: add manpage for dtprobed(8) Nick Alcock
2024-10-29 21:19 ` Kris Van Hees
2024-10-28 21:18 ` [PATCH v2 13/14] man: drop double-\fB at the start of every option line Nick Alcock
2024-10-28 21:18 ` [PATCH v2 14/14] man: \fP-ize Nick Alcock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttcuo9wi.fsf@esperi.org.uk \
--to=nick.alcock@oracle.com \
--cc=dtrace-devel@oss.oracle.com \
--cc=dtrace@lists.linux.dev \
--cc=kris.van.hees@oracle.com \
--cc=sam@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox