[PATCH 1/3] spec: add dtrace.pc to filelist

[PATCH 1/3] spec: add dtrace.pc to filelist

[Kris Van Hees]

Commit 52a18d35 "build: add a pkg-config file for dtrace consumers: use it"
added a dtrace.pc file but failed to add it to the dtrace.spec as well.

Signed-off-by: Kris Van Hees <kris.van.hees@oracle.com>
---
 dtrace.spec | 1 +
 1 file changed, 1 insertion(+)

diff --git a/dtrace.spec b/dtrace.spec
index 1887fcad..c895426b 100644
--- a/dtrace.spec
+++ b/dtrace.spec
@@ -246,6 +246,7 @@ systemctl start dtprobed || :
 %{_libdir}/libdtrace.so.*
 %{_sbindir}/dtrace
 %{_sbindir}/dtprobed
+%{_datadir}/pkgconfig/dtrace.pc
 %{_datadir}/pkgconfig/dtrace_sdt.pc
 %{_mandir}/man8/dtrace.8.gz
 %doc %{_docdir}/dtrace-%{version}/*
-- 
2.42.0

Re: [PATCH 1/3] spec: add dtrace.pc to filelist

[Nick Alcock]

On 11 Nov 2024, Kris Van Hees uttered the following:

> Commit 52a18d35 "build: add a pkg-config file for dtrace consumers: use it"
> added a dtrace.pc file but failed to add it to the dtrace.spec as well.
> 
> Signed-off-by: Kris Van Hees <kris.van.hees@oracle.com>

Wrong package: it's a consumer .pc so it should be in -devel.

(See the patch I just sent when I woke up before, uh, reading any mail.)

-- 
NULL && (void)

Re: [PATCH 1/3] spec: add dtrace.pc to filelist

[Kris Van Hees]

On Mon, Nov 11, 2024 at 03:57:28PM +0000, Nick Alcock wrote:
> On 11 Nov 2024, Kris Van Hees uttered the following:
> 
> > Commit 52a18d35 "build: add a pkg-config file for dtrace consumers: use it"
> > added a dtrace.pc file but failed to add it to the dtrace.spec as well.
> > 
> > Signed-off-by: Kris Van Hees <kris.van.hees@oracle.com>
> 
> Wrong package: it's a consumer .pc so it should be in -devel.
> 
> (See the patch I just sent when I woke up before, uh, reading any mail.)

But dtrace.pc is the pkgconfig file that specifies where dtrace itself is
located.  I honestly would expect that to be part of the main package since
other tools that need dtrace for something would then be able to use pkgconfig
to find dtrace, etc.  Why else would we put the location of the dtrace
executble itself in there?  Without installing -devel you don't get to find
out where dtrace resides, but with -devel installed suddenly that becomes
something relevant?

Re: [PATCH 1/3] spec: add dtrace.pc to filelist

[Nick Alcock]

On 11 Nov 2024, Kris Van Hees stated:

> On Mon, Nov 11, 2024 at 03:57:28PM +0000, Nick Alcock wrote:
>> On 11 Nov 2024, Kris Van Hees uttered the following:
>> 
>> > Commit 52a18d35 "build: add a pkg-config file for dtrace consumers: use it"
>> > added a dtrace.pc file but failed to add it to the dtrace.spec as well.
>> > 
>> > Signed-off-by: Kris Van Hees <kris.van.hees@oracle.com>
>> 
>> Wrong package: it's a consumer .pc so it should be in -devel.
>> 
>> (See the patch I just sent when I woke up before, uh, reading any mail.)
>
> But dtrace.pc is the pkgconfig file that specifies where dtrace itself is
> located.  I honestly would expect that to be part of the main package since
> other tools that need dtrace for something would then be able to use pkgconfig
> to find dtrace, etc.  Why else would we put the location of the dtrace
> executble itself in there?  Without installing -devel you don't get to find
> out where dtrace resides, but with -devel installed suddenly that becomes
> something relevant?

Ahhh. Yeah, sorry, you're probably right: its original purpose was to
specify the -ldtrace path, etc. I quite forgot we're now using it to
report the actual binary path too (mostly because I didn't expect anyone
but the testsuite to ever use it, but that's a totally unjustified
assumption). Objection withdrawn.

(People without the devel package installed will now find
pkgconf --libs dtrace returning something that won't work until they
install it, but I guess this is fairly commonplace among binary packages
that install .pc files -- which must be fairly rare, mind you. I guess
we can see if we get a bug report about it.)

-- 
NULL && (void)