From: Kris Van Hees <kris.van.hees@oracle.com>
To: eugene.loh@oracle.com
Cc: dtrace@lists.linux.dev, dtrace-devel@oss.oracle.com
Subject: Re: [DTrace-devel] [PATCH 4/6] Remove unused function arg
Date: Thu, 9 Jan 2025 14:17:19 -0500 [thread overview]
Message-ID: <Z4Agv1EzqCTv3KJF@oracle.com> (raw)
In-Reply-To: <20241220222716.18511-4-eugene.loh@oracle.com>
On Fri, Dec 20, 2024 at 05:27:14PM -0500, eugene.loh--- via DTrace-devel wrote:
> From: Eugene Loh <eugene.loh@oracle.com>
>
> Signed-off-by: Eugene Loh <eugene.loh@oracle.com>
Reviewed-by: Kris Van Hees <kris.van.hees@oracle.com>
... merging is pending because it depends on earier patches yet to be reviewed.
> ---
> libdtrace/dt_pid.c | 12 +++++-------
> 1 file changed, 5 insertions(+), 7 deletions(-)
>
> diff --git a/libdtrace/dt_pid.c b/libdtrace/dt_pid.c
> index e57478450..b8bbb0396 100644
> --- a/libdtrace/dt_pid.c
> +++ b/libdtrace/dt_pid.c
> @@ -104,7 +104,7 @@ dt_pid_error(dtrace_hdl_t *dtp, dt_pcb_t *pcb, dt_proc_t *dpr,
>
> static int
> dt_pid_create_one_probe(struct ps_prochandle *P, dtrace_hdl_t *dtp,
> - pid_probespec_t *psp, const GElf_Sym *symp, pid_probetype_t type)
> + pid_probespec_t *psp, pid_probetype_t type)
> {
> const dt_provider_t *pvp = dtp->dt_prov_pid;
>
> @@ -184,8 +184,7 @@ dt_pid_per_sym(dt_pid_probe_t *pp, const GElf_Sym *symp, const char *func)
> psp->pps_off = symp->st_value - pp->dpp_vaddr;
>
> if (!isdash && gmatch("return", pp->dpp_name)) {
> - if (dt_pid_create_one_probe(pp->dpp_pr, dtp, psp, symp,
> - DTPPT_RETURN) < 0) {
> + if (dt_pid_create_one_probe(pp->dpp_pr, dtp, psp, DTPPT_RETURN) < 0) {
> rc = dt_pid_error(
> dtp, pcb, dpr, D_PROC_CREATEFAIL,
> "failed to create return probe for '%s': %s",
> @@ -197,8 +196,7 @@ dt_pid_per_sym(dt_pid_probe_t *pp, const GElf_Sym *symp, const char *func)
> }
>
> if (!isdash && gmatch("entry", pp->dpp_name)) {
> - if (dt_pid_create_one_probe(pp->dpp_pr, dtp, psp, symp,
> - DTPPT_ENTRY) < 0) {
> + if (dt_pid_create_one_probe(pp->dpp_pr, dtp, psp, DTPPT_ENTRY) < 0) {
> rc = dt_pid_error(
> dtp, pcb, dpr, D_PROC_CREATEFAIL,
> "failed to create entry probe for '%s': %s",
> @@ -232,7 +230,7 @@ dt_pid_per_sym(dt_pid_probe_t *pp, const GElf_Sym *symp, const char *func)
> psp->pps_nameoff = off;
> psp->pps_off = symp->st_value - pp->dpp_vaddr + off;
> if (dt_pid_create_one_probe(pp->dpp_pr, dtp,
> - psp, symp, DTPPT_OFFSETS) < 0) {
> + psp, DTPPT_OFFSETS) < 0) {
> rc = dt_pid_error(
> dtp, pcb, dpr, D_PROC_CREATEFAIL,
> "failed to create probes at '%s+0x%llx': %s",
> @@ -363,7 +361,7 @@ dt_pid_per_sym(dt_pid_probe_t *pp, const GElf_Sym *symp, const char *func)
> psp->pps_nameoff = off;
> psp->pps_off = symp->st_value - pp->dpp_vaddr + off;
> if (dt_pid_create_one_probe(pp->dpp_pr, dtp,
> - psp, symp, DTPPT_OFFSETS) >= 0)
> + psp, DTPPT_OFFSETS) >= 0)
> nmatches++;
> }
>
> --
> 2.43.5
>
>
> _______________________________________________
> DTrace-devel mailing list
> DTrace-devel@oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/dtrace-devel
next prev parent reply other threads:[~2025-01-09 19:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-20 22:27 [PATCH 1/6] Remove unused dpp_pc and dpp_size eugene.loh
2024-12-20 22:27 ` [PATCH 2/6] Use prb instead of psp.pps_prb eugene.loh
2024-12-20 22:27 ` [PATCH 3/6] Simplify references to dtp eugene.loh
2025-01-09 19:21 ` Kris Van Hees
2024-12-20 22:27 ` [PATCH 4/6] Remove unused function arg eugene.loh
2025-01-09 19:17 ` Kris Van Hees [this message]
2024-12-20 22:27 ` [PATCH 5/6] test: Move disassembly and extracting PCs earlier eugene.loh
2024-12-20 22:27 ` [PATCH 6/6] Add support for pid function "-" with absolute offset eugene.loh
2025-01-09 19:12 ` [DTrace-devel] " Kris Van Hees
2025-01-09 20:52 ` Eugene Loh
2025-01-09 21:00 ` Eugene Loh
2025-01-10 5:07 ` Kris Van Hees
2025-01-10 6:30 ` Eugene Loh
2025-01-10 14:47 ` Kris Van Hees
2025-01-09 19:14 ` [PATCH 1/6] Remove unused dpp_pc and dpp_size Kris Van Hees
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4Agv1EzqCTv3KJF@oracle.com \
--to=kris.van.hees@oracle.com \
--cc=dtrace-devel@oss.oracle.com \
--cc=dtrace@lists.linux.dev \
--cc=eugene.loh@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox