From: Kris Van Hees <kris.van.hees@oracle.com>
To: eugene.loh@oracle.com
Cc: dtrace@lists.linux.dev, dtrace-devel@oss.oracle.com
Subject: Re: [PATCH] Convert some indenting spaces into tabs
Date: Wed, 26 Feb 2025 11:55:18 -0500 [thread overview]
Message-ID: <Z79Hdo7S5zYQvbpc@oracle.com> (raw)
In-Reply-To: <20250114233820.5501-1-eugene.loh@oracle.com>
On Tue, Jan 14, 2025 at 06:38:20PM -0500, eugene.loh@oracle.com wrote:
> From: Eugene Loh <eugene.loh@oracle.com>
>
> Signed-off-by: Eugene Loh <eugene.loh@oracle.com>
Reviewed-by: Kris Van Hees <kris.van.hees@oracle.com>
> ---
> libdtrace/dt_prov_uprobe.c | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/libdtrace/dt_prov_uprobe.c b/libdtrace/dt_prov_uprobe.c
> index e96479963..5d9f74244 100644
> --- a/libdtrace/dt_prov_uprobe.c
> +++ b/libdtrace/dt_prov_uprobe.c
> @@ -593,7 +593,7 @@ static int populate_args(dtrace_hdl_t *dtp, const pid_probespec_t *psp,
> upp->args[i].mapping = map_arg;
> upp->args[i].flags = 0;
>
> - if (i != map_arg)
> + if (i != map_arg)
> upp->flags |= PP_IS_MAPPED;
> }
>
> @@ -716,21 +716,21 @@ static dt_probe_t *create_underlying(dtrace_hdl_t *dtp,
>
> switch (psp->pps_type) {
> case DTPPT_RETURN:
> - upp->flags |= PP_IS_RETURN;
> - break;
> + upp->flags |= PP_IS_RETURN;
> + break;
> case DTPPT_IS_ENABLED:
> - upp->flags |= PP_IS_ENABLED;
> - break;
> + upp->flags |= PP_IS_ENABLED;
> + break;
> case DTPPT_USDT:
> - upp->flags |= PP_IS_USDT;
> - break;
> + upp->flags |= PP_IS_USDT;
> + break;
> default: ;
> - /*
> - * No flags needed for other types.
> - */
> + /*
> + * No flags needed for other types.
> + */
> }
>
> - return uprp;
> + return uprp;
>
> fail:
> dt_dprintf("Failed to instantiate %s:%s:%s:%s\n", psp->pps_prv,
> --
> 2.43.5
>
prev parent reply other threads:[~2025-02-26 16:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-14 23:38 [PATCH] Convert some indenting spaces into tabs eugene.loh
2025-02-26 16:55 ` Kris Van Hees [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z79Hdo7S5zYQvbpc@oracle.com \
--to=kris.van.hees@oracle.com \
--cc=dtrace-devel@oss.oracle.com \
--cc=dtrace@lists.linux.dev \
--cc=eugene.loh@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox