From: Kris Van Hees <kris.van.hees@oracle.com>
To: eugene.loh@oracle.com
Cc: dtrace@lists.linux.dev, dtrace-devel@oss.oracle.com
Subject: Re: [PATCH] test: Improve resilience of tests to ptr widths
Date: Wed, 26 Feb 2025 11:58:25 -0500 [thread overview]
Message-ID: <Z79IMWyCAyZPI8Gh@oracle.com> (raw)
In-Reply-To: <20250128213621.2617-1-eugene.loh@oracle.com>
On Tue, Jan 28, 2025 at 04:36:21PM -0500, eugene.loh@oracle.com wrote:
> From: Eugene Loh <eugene.loh@oracle.com>
>
> When tests are run, runtest.sh runs postprocess(), which among
> other things turns irreproducible hex strings (presumably offsets
> and pointers) into fixed strings (like "ptr") for correctness
> checking. In a few cases, however, there are trailing blanks
> to justify the right margin, meaning that the width of the hex
> string can cause the number of trailing blanks to vary.
>
> Improve the resilience of these tests by stripping out such
> trailing blanks.
>
> Signed-off-by: Eugene Loh <eugene.loh@oracle.com>
Reviewed-by: Kris Van Hees <kris.van.hees@oracle.com>
> ---
> test/unittest/ustack/tst.uaddr-pid0.r | 2 +-
> test/unittest/ustack/tst.uaddr-pid0.r.p | 4 ++++
> test/unittest/ustack/tst.uaddr.r | 2 +-
> test/unittest/ustack/tst.uaddr.r.p | 4 ++++
> test/unittest/ustack/tst.ufunc-pid0.r | 2 +-
> test/unittest/ustack/tst.ufunc-pid0.r.p | 4 ++++
> test/unittest/ustack/tst.usym-pid0.r | 2 +-
> test/unittest/ustack/tst.usym-pid0.r.p | 4 ++++
> 8 files changed, 20 insertions(+), 4 deletions(-)
> create mode 100755 test/unittest/ustack/tst.uaddr-pid0.r.p
> create mode 100755 test/unittest/ustack/tst.uaddr.r.p
> create mode 100755 test/unittest/ustack/tst.ufunc-pid0.r.p
> create mode 100755 test/unittest/ustack/tst.usym-pid0.r.p
>
> diff --git a/test/unittest/ustack/tst.uaddr-pid0.r b/test/unittest/ustack/tst.uaddr-pid0.r
> index a8e68f4e6..cc1cdbc3d 100644
> --- a/test/unittest/ustack/tst.uaddr-pid0.r
> +++ b/test/unittest/ustack/tst.uaddr-pid0.r
> @@ -1 +1 @@
> - {ptr}
> + {ptr}
> diff --git a/test/unittest/ustack/tst.uaddr-pid0.r.p b/test/unittest/ustack/tst.uaddr-pid0.r.p
> new file mode 100755
> index 000000000..9203dc824
> --- /dev/null
> +++ b/test/unittest/ustack/tst.uaddr-pid0.r.p
> @@ -0,0 +1,4 @@
> +#!/usr/bin/gawk -f
> +
> +# remove trailing blanks
> +{ sub(" *$", ""); print }
> diff --git a/test/unittest/ustack/tst.uaddr.r b/test/unittest/ustack/tst.uaddr.r
> index be48a12ab..cc329e213 100644
> --- a/test/unittest/ustack/tst.uaddr.r
> +++ b/test/unittest/ustack/tst.uaddr.r
> @@ -1 +1 @@
> - ustack-tst-basic`myfunc_y+{ptr}
> + ustack-tst-basic`myfunc_y+{ptr}
> diff --git a/test/unittest/ustack/tst.uaddr.r.p b/test/unittest/ustack/tst.uaddr.r.p
> new file mode 100755
> index 000000000..9203dc824
> --- /dev/null
> +++ b/test/unittest/ustack/tst.uaddr.r.p
> @@ -0,0 +1,4 @@
> +#!/usr/bin/gawk -f
> +
> +# remove trailing blanks
> +{ sub(" *$", ""); print }
> diff --git a/test/unittest/ustack/tst.ufunc-pid0.r b/test/unittest/ustack/tst.ufunc-pid0.r
> index a8e68f4e6..cc1cdbc3d 100644
> --- a/test/unittest/ustack/tst.ufunc-pid0.r
> +++ b/test/unittest/ustack/tst.ufunc-pid0.r
> @@ -1 +1 @@
> - {ptr}
> + {ptr}
> diff --git a/test/unittest/ustack/tst.ufunc-pid0.r.p b/test/unittest/ustack/tst.ufunc-pid0.r.p
> new file mode 100755
> index 000000000..9203dc824
> --- /dev/null
> +++ b/test/unittest/ustack/tst.ufunc-pid0.r.p
> @@ -0,0 +1,4 @@
> +#!/usr/bin/gawk -f
> +
> +# remove trailing blanks
> +{ sub(" *$", ""); print }
> diff --git a/test/unittest/ustack/tst.usym-pid0.r b/test/unittest/ustack/tst.usym-pid0.r
> index a8e68f4e6..cc1cdbc3d 100644
> --- a/test/unittest/ustack/tst.usym-pid0.r
> +++ b/test/unittest/ustack/tst.usym-pid0.r
> @@ -1 +1 @@
> - {ptr}
> + {ptr}
> diff --git a/test/unittest/ustack/tst.usym-pid0.r.p b/test/unittest/ustack/tst.usym-pid0.r.p
> new file mode 100755
> index 000000000..9203dc824
> --- /dev/null
> +++ b/test/unittest/ustack/tst.usym-pid0.r.p
> @@ -0,0 +1,4 @@
> +#!/usr/bin/gawk -f
> +
> +# remove trailing blanks
> +{ sub(" *$", ""); print }
> --
> 2.43.5
>
prev parent reply other threads:[~2025-02-26 16:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-28 21:36 [PATCH] test: Improve resilience of tests to ptr widths eugene.loh
2025-02-26 16:58 ` Kris Van Hees [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z79IMWyCAyZPI8Gh@oracle.com \
--to=kris.van.hees@oracle.com \
--cc=dtrace-devel@oss.oracle.com \
--cc=dtrace@lists.linux.dev \
--cc=eugene.loh@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox