From: Kris Van Hees <kris.van.hees@oracle.com>
To: Eugene Loh <eugene.loh@oracle.com>
Cc: Kris Van Hees <kris.van.hees@oracle.com>,
dtrace@lists.linux.dev, dtrace-devel@oss.oracle.com
Subject: Re: [PATCH 6/8] fbt: performance improvements
Date: Mon, 17 Mar 2025 17:15:53 -0400 [thread overview]
Message-ID: <Z9iRCQsY5iJi1VzQ@oracle.com> (raw)
In-Reply-To: <a919bbe3-db2b-5109-a6cb-e7a2745e41b5@oracle.com>
On Mon, Mar 17, 2025 at 05:00:39PM -0400, Eugene Loh wrote:
> On 3/12/25 01:33, Kris Van Hees wrote:
>
> > No change should be needed to the lockstat provider. You uncovered a bug
> > in my patch - I'll fix it.
>
> Just curious why lockstat even used "_*" rather than "_slowpath".
Not sure - maybe there was another variant at some point in time that is no
longer there right now.
> > Incidentally, I also just noticed that dt_modsym_mark_traceable(dtp); is being
> > done too early. We only really need that to be done once we get to looking at
> > function symbols. I'll move it - that way we avoid marking function traceable
> > for probes that cannot be FBT probes because of probe name or module name.
> >
> > I'll send out a v2 tomorrow with that fix.
>
> Okay, I think I see v2. Just checking: does it indeed have
> dt_modsym_mark_traceable() moved?
No, that is being done in the consolidation patch.
next prev parent reply other threads:[~2025-03-17 21:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-07 21:34 [PATCH 2/8] sched: clean up unnecessary includes and functions Kris Van Hees
2025-03-07 21:34 ` [PATCH 3/8] rawfbt: perform lookup on true symbol names Kris Van Hees
2025-03-10 22:03 ` Eugene Loh
2025-03-07 21:34 ` [PATCH 4/8] ksyms: make symbol name filters less picky Kris Van Hees
2025-03-10 22:04 ` Eugene Loh
2025-03-07 21:34 ` [PATCH 5/8] symtab: add support for 'traceable' flag Kris Van Hees
2025-03-18 5:26 ` [DTrace-devel] " Eugene Loh
2025-03-07 21:34 ` [PATCH 6/8] fbt: performance improvements Kris Van Hees
2025-03-12 5:17 ` Eugene Loh
2025-03-12 5:33 ` Kris Van Hees
2025-03-17 21:00 ` Eugene Loh
2025-03-17 21:15 ` Kris Van Hees [this message]
2025-03-07 21:34 ` [PATCH 7/8] rawfbt: " Kris Van Hees
2025-03-07 21:34 ` [PATCH 8/8] fbt, rawfbt: consolidate code to avoid duplication Kris Van Hees
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9iRCQsY5iJi1VzQ@oracle.com \
--to=kris.van.hees@oracle.com \
--cc=dtrace-devel@oss.oracle.com \
--cc=dtrace@lists.linux.dev \
--cc=eugene.loh@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox