From: Kris Van Hees <kris.van.hees@oracle.com>
To: eugene.loh@oracle.com
Cc: dtrace@lists.linux.dev, dtrace-devel@oss.oracle.com
Subject: Re: [DTrace-devel] [PATCH] Get execargs from user space
Date: Wed, 19 Mar 2025 15:07:17 -0400 [thread overview]
Message-ID: <Z9sV5egl8ameuk+u@oracle.com> (raw)
In-Reply-To: <20250319063230.28171-5-eugene.loh@oracle.com>
On Wed, Mar 19, 2025 at 02:32:30AM -0400, eugene.loh--- via DTrace-devel wrote:
> From: Eugene Loh <eugene.loh@oracle.com>
>
> Signed-off-by: Eugene Loh <eugene.loh@oracle.com>
Reviewed-by: Kris Van Hees <kris.van.hees@oracle.com>
I expect this is a failure on arm64 only? That would make sense since it is
the only arch we currently work with for DTrace that has kernels where the
specific probe_read_kernel/user separation is enforced.
I'll fix the comment as indicated below while merging.
> ---
> bpf/bvar_execargs.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/bpf/bvar_execargs.S b/bpf/bvar_execargs.S
> index 1c47cafb2..08844f15f 100644
> --- a/bpf/bvar_execargs.S
> +++ b/bpf/bvar_execargs.S
> @@ -65,7 +65,7 @@ dt_bvar_execargs:
> mov %r1, %r9
> mov %r2, %r8
> mov %r3, %r7
> - call BPF_FUNC_probe_read /* bpf_probe_read(&args, len + 1, arg_start) */
> + call BPF_FUNC_probe_read_user /* bpf_probe_read(&args, len + 1, arg_start) */
comment should also mention bpf_probe_read_user
> jne %r0, 0, .Lerror
>
> /* loop over args and replace '\0' with ' ' */
> --
> 2.43.5
>
>
> _______________________________________________
> DTrace-devel mailing list
> DTrace-devel@oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/dtrace-devel
next prev parent reply other threads:[~2025-03-19 19:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-19 6:32 [PATCH] test: Account for pid:::entry ucaller being correct eugene.loh
2025-03-19 6:32 ` [PATCH] Fix dt_bvar_probedesc() for late USDT processes eugene.loh
2025-03-19 18:54 ` Kris Van Hees
2025-03-19 6:32 ` [PATCH] Copy fprobes entry args with BPF helper function eugene.loh
2025-03-19 18:58 ` Kris Van Hees
2025-03-19 6:32 ` [PATCH] test: Expect USDT argmap to fail on ARM on older kernels eugene.loh
2025-03-19 19:04 ` [DTrace-devel] " Kris Van Hees
2025-04-11 20:37 ` Kris Van Hees
2025-03-19 6:32 ` [PATCH] Get execargs from user space eugene.loh
2025-03-19 19:07 ` Kris Van Hees [this message]
2025-03-19 19:19 ` [DTrace-devel] " Eugene Loh
2025-03-19 18:53 ` [PATCH] test: Account for pid:::entry ucaller being correct Kris Van Hees
2025-04-14 23:33 ` [DTrace-devel] " Sam James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9sV5egl8ameuk+u@oracle.com \
--to=kris.van.hees@oracle.com \
--cc=dtrace-devel@oss.oracle.com \
--cc=dtrace@lists.linux.dev \
--cc=eugene.loh@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox