Linux DTrace development list
 help / color / mirror / Atom feed
From: Kris Van Hees <kris.van.hees@oracle.com>
To: Alan Maguire <alan.maguire@oracle.com>
Cc: dtrace@lists.linux.dev, dtrace-devel@oss.oracle.com
Subject: Re: [PATCH v2 2/2] unittest/sched: remove dtv2 xfail
Date: Fri, 16 Aug 2024 20:28:36 -0400	[thread overview]
Message-ID: <Zr/utNV5KswtGN3U@oracle.com> (raw)
In-Reply-To: <Zr+pbCfu2apcbDAd@oracle.com>

Problem found: the OL9 UEK7 kernel I am working with (and possibly all) does
not allow an FBT probe on __perf_event_task_sched_in.  The failure is silent,
causing the probe to simply never get enabled and no error reported, so the
probe does not fire and causes the test to fail.

In other words... the approach in 1/2 of this series does *not* seem to work
for OL7 kernels.  That is a problem.

On Fri, Aug 16, 2024 at 03:33:00PM -0400, Kris Van Hees wrote:
> Running a full testsuite run (and then also individual test) I found this
> test to fail on my OL9 VM with 5.15.0-205.149.5.1.el9uek.x86_64 kernel
> while it works on my Debian VM with a 6.5.0 kernel.
> 
> On Fri, Aug 02, 2024 at 05:37:11PM -0400, Kris Van Hees wrote:
> > On Fri, Jun 28, 2024 at 06:16:34PM +0100, Alan Maguire wrote:
> > > ...since tst.oncpu.d test passes now.
> > > 
> > > Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
> > 
> > Reviewed-by: Kris Van Hees <kris.van.hees@oracle.com>
> > 
> > > ---
> > >  test/unittest/sched/tst.oncpu.d | 3 +--
> > >  1 file changed, 1 insertion(+), 2 deletions(-)
> > > 
> > > diff --git a/test/unittest/sched/tst.oncpu.d b/test/unittest/sched/tst.oncpu.d
> > > index d2c2ce57..7a33bab4 100644
> > > --- a/test/unittest/sched/tst.oncpu.d
> > > +++ b/test/unittest/sched/tst.oncpu.d
> > > @@ -1,11 +1,10 @@
> > >  /*
> > >   * Oracle Linux DTrace.
> > > - * Copyright (c) 2006, 2020, Oracle and/or its affiliates. All rights reserved.
> > > + * Copyright (c) 2006, 2024, Oracle and/or its affiliates. All rights reserved.
> > >   * Licensed under the Universal Permissive License v 1.0 as shown at
> > >   * http://oss.oracle.com/licenses/upl.
> > >   */
> > >  
> > > -/* @@xfail: dtv2 */
> > >  /* @@timeout: 15 */
> > >  
> > >  #pragma D option switchrate=100hz
> > > -- 
> > > 2.43.5
> > > 

  reply	other threads:[~2024-08-17  0:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-28 17:16 [PATCH v2 1/2] sched: fix firing of sched:::on-cpu Alan Maguire
2024-06-28 17:16 ` [PATCH v2 2/2] unittest/sched: remove dtv2 xfail Alan Maguire
2024-08-02 21:37   ` Kris Van Hees
2024-08-16 19:33     ` Kris Van Hees
2024-08-17  0:28       ` Kris Van Hees [this message]
2024-08-28 16:58         ` Alan Maguire
2024-10-07 19:10           ` Kris Van Hees
2024-10-08 18:17             ` Alan Maguire
2024-08-02 21:36 ` [DTrace-devel] [PATCH v2 1/2] sched: fix firing of sched:::on-cpu Kris Van Hees

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zr/utNV5KswtGN3U@oracle.com \
    --to=kris.van.hees@oracle.com \
    --cc=alan.maguire@oracle.com \
    --cc=dtrace-devel@oss.oracle.com \
    --cc=dtrace@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox