From: Kris Van Hees <kris.van.hees@oracle.com>
To: eugene.loh@oracle.com
Cc: dtrace@lists.linux.dev, dtrace-devel@oss.oracle.com
Subject: Re: [DTrace-devel] [PATCH 8/8] Turn some leading spaces into tabs
Date: Mon, 19 Aug 2024 19:34:31 -0400 [thread overview]
Message-ID: <ZsPWhw6bq5b9yuEI@oracle.com> (raw)
In-Reply-To: <20240604180008.11331-8-eugene.loh@oracle.com>
On Tue, Jun 04, 2024 at 02:00:08PM -0400, eugene.loh--- via DTrace-devel wrote:
> From: Eugene Loh <eugene.loh@oracle.com>
>
> Signed-off-by: Eugene Loh <eugene.loh@oracle.com>
Reviewed-by: Kris Van Hees <kris.van.hees@oracle.com>
> ---
> libdtrace/dt_bpf.c | 2 +-
> libdtrace/dt_pid.c | 8 ++++----
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/libdtrace/dt_bpf.c b/libdtrace/dt_bpf.c
> index e1a09215..71c6a446 100644
> --- a/libdtrace/dt_bpf.c
> +++ b/libdtrace/dt_bpf.c
> @@ -1140,7 +1140,7 @@ dt_bpf_load_prog(dtrace_hdl_t *dtp, const dt_probe_t *prp,
>
> snprintf(msg, sizeof(msg),
> "BPF program load for '%s:%s:%s:%s' failed",
> - pdp->prv, pdp->mod, pdp->fun, pdp->prb);
> + pdp->prv, pdp->mod, pdp->fun, pdp->prb);
> if (err == EPERM)
> return dt_bpf_lockmem_error(dtp, msg);
> dt_bpf_error(dtp, "%s: %s\n", msg,
> diff --git a/libdtrace/dt_pid.c b/libdtrace/dt_pid.c
> index 02ed7511..7c7d7e30 100644
> --- a/libdtrace/dt_pid.c
> +++ b/libdtrace/dt_pid.c
> @@ -905,7 +905,7 @@ dt_pid_create_usdt_probes(dtrace_hdl_t *dtp, dt_proc_t *dpr, dtrace_probedesc_t
> provider = (dof_parsed_t *) p;
> if (!validate_dof_record(path, provider, DIT_PROVIDER, dof_buf_size,
> seen_size))
> - goto parse_err;
> + goto parse_err;
>
> prv = provider->provider.name;
>
> @@ -915,16 +915,16 @@ dt_pid_create_usdt_probes(dtrace_hdl_t *dtp, dt_proc_t *dpr, dtrace_probedesc_t
> probe = (dof_parsed_t *) p;
> if (!validate_dof_record(path, probe, DIT_PROBE, dof_buf_size,
> seen_size))
> - goto parse_err;
> + goto parse_err;
>
> - mod = probe->probe.name;
> + mod = probe->probe.name;
> fun = mod + strlen(mod) + 1;
> prb = fun + strlen(fun) + 1;
>
> p += probe->size;
> seen_size += probe->size;
>
> - /*
> + /*
> * Now the parsed DOF for this probe's tracepoints.
> */
> for (size_t j = 0; j < probe->probe.ntp; j++) {
> --
> 2.18.4
>
>
> _______________________________________________
> DTrace-devel mailing list
> DTrace-devel@oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/dtrace-devel
next prev parent reply other threads:[~2024-08-19 23:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 18:00 [PATCH 1/8] test: Allow aggpercpu test to omit some CPUs eugene.loh
2024-06-04 18:00 ` [PATCH 2/8] Reduce stack depth if kernel returns NULL frames eugene.loh
2024-08-19 23:30 ` [DTrace-devel] " Kris Van Hees
2024-08-28 20:11 ` Eugene Loh
2024-08-28 20:17 ` Kris Van Hees
2024-08-28 20:23 ` Eugene Loh
2024-08-28 20:37 ` Kris Van Hees
2025-08-13 5:12 ` Eugene Loh
2024-06-04 18:00 ` [PATCH 3/8] test: Fix nonexistent @@sort option eugene.loh
2024-08-19 23:15 ` [DTrace-devel] " Kris Van Hees
2024-06-04 18:00 ` [PATCH 4/8] test: Remove unneeded -w option eugene.loh
2024-08-19 23:12 ` [DTrace-devel] " Kris Van Hees
2024-06-04 18:00 ` [PATCH 5/8] Fix stddev() carryover computation eugene.loh
2024-08-19 23:13 ` [DTrace-devel] " Kris Van Hees
2024-06-04 18:00 ` [PATCH 6/8] test: Check dtrace return status eugene.loh
2024-06-04 18:00 ` [PATCH 7/8] Clean up double semicolons eugene.loh
2024-08-19 23:34 ` [DTrace-devel] " Kris Van Hees
2024-06-04 18:00 ` [PATCH 8/8] Turn some leading spaces into tabs eugene.loh
2024-08-19 23:34 ` Kris Van Hees [this message]
2024-08-19 23:11 ` [PATCH 1/8] test: Allow aggpercpu test to omit some CPUs Kris Van Hees
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZsPWhw6bq5b9yuEI@oracle.com \
--to=kris.van.hees@oracle.com \
--cc=dtrace-devel@oss.oracle.com \
--cc=dtrace@lists.linux.dev \
--cc=eugene.loh@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox