Re: [PATCH 19/22] test: Fix tst.probestar.d trigger

Kris Van Hees
2024-09-14T18:13:35Z

Given that the patch also adds a FIXME, I think that it would be better to
resolve whatever that FIXME is meant to refer to before we merge this.

:On Thu, Aug 29, 2024 at 01:22:16AM -0400, eugene.loh@oracle.com wrote:
> From: Eugene Loh <eugene.loh@oracle.com>
>
> This test was relying on a trigger that uses the obsolete
> dt_test, even though dt_test is irrelevant to the test.
>
> Use a different trigger.
>
> Signed-off-by: Eugene Loh <eugene.loh@oracle.com>
> ---
> test/unittest/probes/tst.probestar.d | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/test/unittest/probes/tst.probestar.d b/test/unittest/probes/tst.probestar.d
> index dad7741e..b6da42e1 100644
> --- a/test/unittest/probes/tst.probestar.d
> +++ b/test/unittest/probes/tst.probestar.d
> @@ -1,11 +1,11 @@
> /*
> * Oracle Linux DTrace.
> - * Copyright (c) 2011, 2020, Oracle and/or its affiliates. All rights reserved.
> + * Copyright (c) 2011, 2024, Oracle and/or its affiliates. All rights reserved.
> * Licensed under the Universal Permissive License v 1.0 as shown at
> * http://oss.oracle.com/licenses/upl.
> */
> -/* @@xfail: dtv2 */
> -/* @@trigger: testprobe */
> +/* @@trigger: readwholedir */
> +/* FIXME */
>
> /*
> * ASSERTION:
> @@ -16,7 +16,6 @@
> *
> */
>
> -
> #pragma D option quiet
>
> int i;
> --
> 2.43.5
>