Re: [PATCH 3/3] test: fix exit code in tst.newprobes.sh

[Kris Van Hees <kris.van.hees@oracle.com>]

On Fri, Oct 11, 2024 at 11:55:33PM -0400, Eugene Loh wrote:
> Maybe I am a few patches behind.  I thought this test used pid*:awk:: and
> was therefore XFAIL.  I do not object to the patch, but I was only curious
> if we wanted a "real fix" to the test. There are other cases where tests
> have multiple problems and we do not generally seem to settle for fixing
> only one of the problems. Again, though, I'm okay with the patch... it's an
> improvement over what's there.

In general, yes, when we encounter a case like this we tend to fix other more
fundamental problems with the test.  In this case, since it is part of a larger
series of test clean up work, I took it as-is so as to not delay the cleanup
any longer.  But yes, the test will still need extra work to ensure it is
actually correct in terms of functionality.

> On 10/11/24 23:29, Kris Van Hees wrote:
> > On Tue, Aug 20, 2024 at 01:10:22AM +0100, Sam James wrote:
> > > $status is never assigned, just use $?.
> > Reviewed-by: Kris Van Hees <kris.van.hees@oracle.com>
> > 
> > ... and committed with Signed-off-by added.
> > 
> > > ---
> > >   test/unittest/pid/tst.newprobes.sh | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/test/unittest/pid/tst.newprobes.sh b/test/unittest/pid/tst.newprobes.sh
> > > index a4944688..0980d3b3 100755
> > > --- a/test/unittest/pid/tst.newprobes.sh
> > > +++ b/test/unittest/pid/tst.newprobes.sh
> > > @@ -44,4 +44,4 @@ tick-1s
> > >   }
> > >   EOF
> > > -exit $status
> > > +exit $?
> > > -- 
> > > 2.46.0
> > >