From: Kris Van Hees <kris.van.hees@oracle.com>
To: Sam James <sam@gentoo.org>
Cc: dtrace@lists.linux.dev
Subject: Re: [PATCH 1/6] test: fix missing line continuation in tst.perf-types.sh
Date: Fri, 11 Oct 2024 23:29:52 -0400 [thread overview]
Message-ID: <ZwntMF0m7h5bNwvN@oracle.com> (raw)
In-Reply-To: <7a1c6618639a057dc267d2e0dc9c9d8afea6b0b1.1724962546.git.sam@gentoo.org>
On Thu, Aug 29, 2024 at 09:15:41PM +0100, Sam James wrote:
> shellcheck reports:
> ```
> In test/unittest/sdt/tst.perf-types.sh line 14:
> -n 'END / hitany == 0 / { exit(1); }'
> ^-- SC2215 (warning): This flag is used as a command name. Bad line break or missing [ .. ]?
> ```
>
> Add the missing '\'.
Reviewed-by: Kris Van Hees <kris.van.hees@oracle.com>
... and committed with Signed-off-by added.
> ---
> test/unittest/sdt/tst.perf-types.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/unittest/sdt/tst.perf-types.sh b/test/unittest/sdt/tst.perf-types.sh
> index 636ed029..2b076110 100755
> --- a/test/unittest/sdt/tst.perf-types.sh
> +++ b/test/unittest/sdt/tst.perf-types.sh
> @@ -10,5 +10,5 @@
> dtrace=$1
>
> exec $dtrace $dt_flags -c "find /dev/dtrace -exec /bin/true ;" \
> - -n 'perf:::sched_process_fork { trace(args[0]->pid); trace (args[1]->pid); hitany = 1; }'
> + -n 'perf:::sched_process_fork { trace(args[0]->pid); trace (args[1]->pid); hitany = 1; }' \
> -n 'END / hitany == 0 / { exit(1); }'
>
> base-commit: 98848d2e4994e916317db3328dc560128235791a
> --
> 2.46.0
>
prev parent reply other threads:[~2024-10-12 3:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-29 20:15 [PATCH 1/6] test: fix missing line continuation in tst.perf-types.sh Sam James
2024-08-29 20:15 ` [PATCH 2/6] test: fix broken shebang in tst.plddGrab32.sh Sam James
2024-10-12 3:30 ` Kris Van Hees
2024-08-29 20:15 ` [PATCH 3/6] test: awk -> gawk where we use strtonum Sam James
2024-10-12 3:30 ` Kris Van Hees
2024-08-29 20:15 ` [PATCH 4/6] test: fix 'CPU' typo Sam James
2024-10-12 3:30 ` Kris Van Hees
2024-08-29 20:15 ` [PATCH 5/6] test: libproc: cater to merged-usr systems Sam James
2024-10-12 3:30 ` Kris Van Hees
2024-08-29 20:15 ` [PATCH 6/6] test: awk -> gawk universally Sam James
2024-10-12 3:31 ` Kris Van Hees
2024-10-12 3:29 ` Kris Van Hees [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZwntMF0m7h5bNwvN@oracle.com \
--to=kris.van.hees@oracle.com \
--cc=dtrace@lists.linux.dev \
--cc=sam@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox