Re: [PATCH 1/2] test: Clean up tst.specopen.d

[Kris Van Hees <kris.van.hees@oracle.com>]

On Mon, Oct 28, 2024 at 02:33:33PM -0400, eugene.loh@oracle.com wrote:
> From: Eugene Loh <eugene.loh@oracle.com>
> 
> The test does not do much.  Mostly, it is a speculation demo.
> It just needed some syntactical cleanup to pass.
> 
> Signed-off-by: Eugene Loh <eugene.loh@oracle.com>

Reviewed-by: Kris Van Hees <kris.van.hees@oracle.com>

> ---
>  test/demo/spec/specopen.d | 11 ++++-------
>  1 file changed, 4 insertions(+), 7 deletions(-)
> 
> diff --git a/test/demo/spec/specopen.d b/test/demo/spec/specopen.d
> index c510045b8..700bdd9ff 100644
> --- a/test/demo/spec/specopen.d
> +++ b/test/demo/spec/specopen.d
> @@ -7,10 +7,7 @@
>   * http://oss.oracle.com/licenses/upl.
>   */
>  
> -/* @@runtest-opts: $_pid */
> -/* @@xfail: fbt provider not yet implemented; needs a trigger with failing open()s */
> -
> -syscall::open:entry,
> +syscall::open:entry
>  {
>  	/*
>  	 * The call to speculation() creates a new speculation.  If this fails,
> @@ -38,7 +35,7 @@ fbt:::
>  	speculate(self->spec);
>  }
>  
> -syscall::open:return,
> +syscall::open:return
>  /self->spec/
>  {
>  	/*
> @@ -51,7 +48,7 @@ syscall::open:return,
>  	trace(errno);
>  }
>  
> -syscall::open:return,
> +syscall::open:return
>  /self->spec && errno != 0/
>  {
>  	/*
> @@ -61,7 +58,7 @@ syscall::open:return,
>  	self->spec = 0;
>  }
>  
> -syscall::open:return,
> +syscall::open:return
>  /self->spec && errno == 0/
>  {
>  	/*
> -- 
> 2.43.5
>