From: Kris Van Hees <kris.van.hees@oracle.com>
To: Nick Alcock <nick.alcock@oracle.com>
Cc: dtrace@lists.linux.dev, dtrace-devel@oss.oracle.com
Subject: Re: [PATCH 1/6] error: add missing EDT_PRINT entry
Date: Tue, 22 Oct 2024 10:40:35 -0400 [thread overview]
Message-ID: <Zxe5Y7KUYloPHCG4@oracle.com> (raw)
In-Reply-To: <20241018195808.270688-2-nick.alcock@oracle.com>
On Fri, Oct 18, 2024 at 08:58:03PM +0100, Nick Alcock wrote:
> The lack of this made it impossible to print out the last error
> in the list (which is EDT_PRINT itself).
>
> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Reviewed-by: Kris Van Hees <kris.van.hees@oracle.com>
> ---
> libdtrace/dt_error.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/libdtrace/dt_error.c b/libdtrace/dt_error.c
> index 82e114a5b292..213f0d9e1385 100644
> --- a/libdtrace/dt_error.c
> +++ b/libdtrace/dt_error.c
> @@ -97,7 +97,8 @@ static const struct {
> { EDT_OBJIO, "Cannot read object file or modules.dep" },
> { EDT_READMAXSTACK, "Cannot read kernel param perf_event_max_stack" },
> { EDT_TRACEMEM, "Missing or corrupt tracemem() record" },
> - { EDT_PCAP, "Missing or corrupt pcap() record" }
> + { EDT_PCAP, "Missing or corrupt pcap() record" },
> + { EDT_PRINT, "Missing or corrupt print() record" }
> };
>
> static const int _dt_nerr = sizeof(_dt_errlist) / sizeof(_dt_errlist[0]);
> --
> 2.46.0.278.g36e3a12567
>
next prev parent reply other threads:[~2024-10-22 14:40 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-18 19:58 [PATCH 0/6] usdt typed args, translators and arg remapping Nick Alcock
2024-10-18 19:58 ` [PATCH 1/6] error: add missing EDT_PRINT entry Nick Alcock
2024-10-21 9:10 ` Alan Maguire
2024-10-22 14:40 ` Kris Van Hees [this message]
2024-10-18 19:58 ` [PATCH 2/6] usdt: get arg types and xlations into DTrace from the DOF Nick Alcock
2024-10-22 17:03 ` Kris Van Hees
2024-10-18 19:58 ` [PATCH 3/6] dtprobed: stop skipping zero-tracepoint probes in dof_stash.c Nick Alcock
2024-10-22 17:12 ` Kris Van Hees
2024-10-24 14:12 ` Nick Alcock
2024-10-18 19:58 ` [PATCH 4/6] cg: add argument remapping in the trampoline Nick Alcock
2024-10-22 17:43 ` Kris Van Hees
2024-10-25 15:56 ` Nick Alcock
2024-10-25 19:15 ` Kris Van Hees
2024-10-28 21:11 ` Nick Alcock
2024-10-28 21:20 ` Kris Van Hees
2024-10-29 13:09 ` Nick Alcock
2024-10-29 14:51 ` Kris Van Hees
2024-10-18 19:58 ` [PATCH 5/6] usdt: typed args and arg remapping Nick Alcock
2024-10-22 18:40 ` Kris Van Hees
2024-10-28 12:52 ` Nick Alcock
2024-10-28 16:00 ` Kris Van Hees
2024-10-18 19:58 ` [PATCH 6/6] usdt: fix create_underlying error path Nick Alcock
2024-10-22 18:46 ` Kris Van Hees
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zxe5Y7KUYloPHCG4@oracle.com \
--to=kris.van.hees@oracle.com \
--cc=dtrace-devel@oss.oracle.com \
--cc=dtrace@lists.linux.dev \
--cc=nick.alcock@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox