Re: [PATCH 3/6] dtprobed: stop skipping zero-tracepoint probes in dof_stash.c

[Kris Van Hees <kris.van.hees@oracle.com>]

On Fri, Oct 18, 2024 at 08:58:05PM +0100, Nick Alcock wrote:
> We already validate that they don't exist in dof_parser.c, so no such probes
> can ever get here.  Handling this impossible, untestable case has just got
> harder, because we'd have to skip DIT_{NATIVE,XLAT,REMAP}_ARGS records too.
> Just stop considering it.
> 
> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>

Reviewed-by: Kris Van Hees <kris.van.hees@oracle.com>

> ---
>  dtprobed/dof_stash.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/dtprobed/dof_stash.c b/dtprobed/dof_stash.c
> index d9731844066c..cc2284aadbc0 100644
> --- a/dtprobed/dof_stash.c
> +++ b/dtprobed/dof_stash.c
> @@ -585,12 +585,6 @@ dof_stash_write_parsed(pid_t pid, dev_t dev, ino_t ino, dt_list_t *accum)
>  			if (err != 0)
>  				goto err_provider;
>  
> -			/*
> -			 * Skip probes with zero tracepoints entirely.
> -			 */
> -			if (accump->parsed->probe.ntp == 0)
> -				break;
> -
>  			mod = accump->parsed->probe.name;
>  			assert(accump->parsed->size > (mod - (char *) accump->parsed));
>  			fun = mod + strlen(mod) + 1;
> -- 
> 2.46.0.278.g36e3a12567
>