Re: [PATCH 04/14] build: substitute LIBDIR in pkg-config files

[Kris Van Hees <kris.van.hees@oracle.com>]

On Thu, Oct 24, 2024 at 12:37:48PM +0100, Nick Alcock wrote:
> /usr/share/pkgconfig/dtrace.pc says
> 
> libdir = @LIBDIR@
> /* ... */
> Libs: -L${libdir} -ldtrace
> 
> which is unlikely to work.
> 
> Fix by substituting LIBDIR properly.
> 
> (I looked at these pkg-config files after installation I don't know how many
> times and never once spotted this incredibly obvious problem.)
> 
> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
> Bug: https://github.com/oracle/dtrace-utils/issues/104

Bug: before Signed-of-by:.

With that...
Reviewed-by: Kris Van Hees <kris.van.hees@oracle.com>

> ---
>  uts/Build | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/uts/Build b/uts/Build
> index 181819410624..65ddc39845c1 100644
> --- a/uts/Build
> +++ b/uts/Build
> @@ -37,6 +37,7 @@ install::
>  		(cd $(uts_DIR) && \
>  		    sed -e 's,@SDTINCLUDEDIR@,$(SDTINCLUDEDIR),g;' \
>  			-e 's,@INCLUDEDIR@,$(INCLUDEDIR),g;' \
> +			-e 's,@LIBDIR@,$(LIBDIR),g;' \
>  			-e 's,@VERSION@,$(VERSION),g;' \
>  			-e 's,@DTRACE@,$(SBINDIR)/dtrace,g' < \
>  			$${name}.in > $(INSTPKGCONFIGDIR)/$$name;) \
> -- 
> 2.46.0.278.g36e3a12567
>