public inbox for dtrace@lists.linux.dev
 help / color / mirror / Atom feed
From: Kris Van Hees <kris.van.hees@oracle.com>
To: eugene.loh@oracle.com
Cc: dtrace@lists.linux.dev, dtrace-devel@oss.oracle.com
Subject: Re: [PATCH 3/6] test: Remove some outdated and unhelpful comments
Date: Fri, 25 Oct 2024 16:53:49 -0400	[thread overview]
Message-ID: <ZxwFXacgFFIwUECd@kvh-deb-bpf.us.oracle.com> (raw)
In-Reply-To: <20240928022158.9206-3-eugene.loh@oracle.com>

On Fri, Sep 27, 2024 at 10:21:55PM -0400, eugene.loh@oracle.com wrote:
> From: Eugene Loh <eugene.loh@oracle.com>
> 
> Signed-off-by: Eugene Loh <eugene.loh@oracle.com>

Reviewed-by: Kris Van Hees <kris.van.hees@oracle.com>

> ---
>  test/triggers/Build | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/test/triggers/Build b/test/triggers/Build
> index 0e8660e59..db80b30ed 100644
> --- a/test/triggers/Build
> +++ b/test/triggers/Build
> @@ -192,18 +192,18 @@ pid-tst-weak1_CFLAGS := -O0
>  pid-tst-weak2_CFLAGS := -O0
>  profile-tst-ufuncsort_CFLAGS := -O0
>  
> -# usdt-tst-argmap calls USDT probes (defined in argmap.d) using sys/sdt.h
> +# usdt-tst-argmap calls USDT probes using sys/sdt.h
>  usdt-tst-argmap_CFLAGS := -Iuts/common
>  usdt-tst-argmap_PROV := usdt-tst-argmap-prov.d
>  
> -# usdt-tst-args calls USDT probes (defined in args.d) using sys/sdt.h
> +# usdt-tst-args calls USDT probes using sys/sdt.h
>  usdt-tst-args_CFLAGS := -Iuts/common
>  usdt-tst-args_PROV := usdt-tst-args-prov.d
>  
> -# usdt-tst-forker calls USDT probes (defined in args.d) based on dtrace -h
> +# usdt-tst-forker calls USDT probes based on dtrace -h
>  usdt-tst-forker_PROV := usdt-tst-forker-prov.d
>  
> -# usdt-tst-special calls USDT probes (defined in prov.d) based on dtrace -h
> +# usdt-tst-special calls USDT probes based on dtrace -h
>  usdt-tst-special_CFLAGS := -fno-inline -O2
>  usdt-tst-special_PROV := usdt-tst-special-prov.d
>  
> -- 
> 2.43.5
> 

  reply	other threads:[~2024-10-25 20:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-28  2:21 [PATCH 1/6] Deferred attach of underlying USDT probes eugene.loh
2024-09-28  2:21 ` [PATCH 2/6] test: Correct long-standing dt_flags typo eugene.loh
2024-10-25 20:48   ` Kris Van Hees
2024-09-28  2:21 ` [PATCH 3/6] test: Remove some outdated and unhelpful comments eugene.loh
2024-10-25 20:53   ` Kris Van Hees [this message]
2024-09-28  2:21 ` [PATCH 4/6] test: Add a USDT "deferred" test trigger eugene.loh
2024-10-28 20:32   ` Kris Van Hees
2024-09-28  2:21 ` [PATCH 5/6] test: Add USDT tests for deferred detection eugene.loh
2024-09-28  2:21 ` [PATCH 6/6] test: Add USDT error tests for -w and -Z eugene.loh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZxwFXacgFFIwUECd@kvh-deb-bpf.us.oracle.com \
    --to=kris.van.hees@oracle.com \
    --cc=dtrace-devel@oss.oracle.com \
    --cc=dtrace@lists.linux.dev \
    --cc=eugene.loh@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox