* [PATCH] test: Remove duplicated check
@ 2024-11-04 19:23 eugene.loh
2024-11-05 19:29 ` Kris Van Hees
0 siblings, 1 reply; 2+ messages in thread
From: eugene.loh @ 2024-11-04 19:23 UTC (permalink / raw)
To: dtrace, dtrace-devel
From: Eugene Loh <eugene.loh@oracle.com>
Signed-off-by: Eugene Loh <eugene.loh@oracle.com>
---
test/unittest/usdt/tst.pidprobes.sh | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/test/unittest/usdt/tst.pidprobes.sh b/test/unittest/usdt/tst.pidprobes.sh
index 8d18c89a4..25fee8553 100755
--- a/test/unittest/usdt/tst.pidprobes.sh
+++ b/test/unittest/usdt/tst.pidprobes.sh
@@ -99,15 +99,6 @@ if [ $? -ne 0 ]; then
cat dtrace.out
exit 1
fi
-echo "my result: 10" > main.out2.expected
-if ! diff -q main.out2 main.out2.expected > /dev/null; then
- echo '"my result"' looks wrong when using DTrace
- echo === got ===
- cat main.out2
- echo === expected ===
- cat main.out2.expected
- exit 1
-fi
# Check that the program output is 10 when the USDT probe is enabled.
# That is, the PYRAMID_ENTRY_ENABLED() is-enabled checks should pass.
@@ -115,7 +106,7 @@ fi
echo "my result: 10" > main.out2.expected
if ! diff -q main.out2 main.out2.expected > /dev/null; then
- echo '"my result"' looks wrong
+ echo '"my result"' looks wrong when using DTrace
echo === got ===
cat main.out2
echo === expected ===
--
2.43.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] test: Remove duplicated check
2024-11-04 19:23 [PATCH] test: Remove duplicated check eugene.loh
@ 2024-11-05 19:29 ` Kris Van Hees
0 siblings, 0 replies; 2+ messages in thread
From: Kris Van Hees @ 2024-11-05 19:29 UTC (permalink / raw)
To: eugene.loh; +Cc: dtrace, dtrace-devel
On Mon, Nov 04, 2024 at 02:23:54PM -0500, eugene.loh@oracle.com wrote:
> From: Eugene Loh <eugene.loh@oracle.com>
>
> Signed-off-by: Eugene Loh <eugene.loh@oracle.com>
Reviewed-by: Kris Van Hees <kris.van.hees@oracle.com>
> ---
> test/unittest/usdt/tst.pidprobes.sh | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)
>
> diff --git a/test/unittest/usdt/tst.pidprobes.sh b/test/unittest/usdt/tst.pidprobes.sh
> index 8d18c89a4..25fee8553 100755
> --- a/test/unittest/usdt/tst.pidprobes.sh
> +++ b/test/unittest/usdt/tst.pidprobes.sh
> @@ -99,15 +99,6 @@ if [ $? -ne 0 ]; then
> cat dtrace.out
> exit 1
> fi
> -echo "my result: 10" > main.out2.expected
> -if ! diff -q main.out2 main.out2.expected > /dev/null; then
> - echo '"my result"' looks wrong when using DTrace
> - echo === got ===
> - cat main.out2
> - echo === expected ===
> - cat main.out2.expected
> - exit 1
> -fi
>
> # Check that the program output is 10 when the USDT probe is enabled.
> # That is, the PYRAMID_ENTRY_ENABLED() is-enabled checks should pass.
> @@ -115,7 +106,7 @@ fi
> echo "my result: 10" > main.out2.expected
>
> if ! diff -q main.out2 main.out2.expected > /dev/null; then
> - echo '"my result"' looks wrong
> + echo '"my result"' looks wrong when using DTrace
> echo === got ===
> cat main.out2
> echo === expected ===
> --
> 2.43.5
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-11-05 19:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-04 19:23 [PATCH] test: Remove duplicated check eugene.loh
2024-11-05 19:29 ` Kris Van Hees
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox