public inbox for dtrace@lists.linux.dev
 help / color / mirror / Atom feed
From: Kris Van Hees <kris.van.hees@oracle.com>
To: Nick Alcock <nick.alcock@oracle.com>
Cc: dtrace@lists.linux.dev, dtrace-devel@oss.oracle.com, sam@gentoo.org
Subject: Re: [PATCH] build: mkdir man directories before installing to them
Date: Tue, 5 Nov 2024 14:32:02 -0500	[thread overview]
Message-ID: <ZypysvRLq1jLnnft@oracle.com> (raw)
In-Reply-To: <20241031174002.260385-1-nick.alcock@oracle.com>

On Thu, Oct 31, 2024 at 05:40:02PM +0000, Nick Alcock wrote:
> You need this for DESTDIR installs.
> 
> Bug: https://github.com/oracle/dtrace-utils/issues/106
> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>

Reviewed-by: Kris Van Hees <kris.van.hees@oracle.com>

> ---
>  cmd/Build      | 2 +-
>  dtprobed/Build | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/cmd/Build b/cmd/Build
> index 38a538c1e3c9..98d0ebd7e5c9 100644
> --- a/cmd/Build
> +++ b/cmd/Build
> @@ -50,7 +50,7 @@ fi\n"
>  
>  
>  install::
> -	mkdir -p $(INSTBINDIR) $(INSTSBINDIR) $(INSTMANDIR) \
> +	mkdir -p $(INSTBINDIR) $(INSTSBINDIR) $(INSTMANDIR)/man8 \
>  	      $(INSTLIBDIR)/dtrace
>  	$(call describe-install-target,$(INSTSBINDIR),dtrace)
>  	install -m 755 $(objdir)/dtrace $(INSTSBINDIR)
> diff --git a/dtprobed/Build b/dtprobed/Build
> index 7d98ddf836c3..c43b62778381 100644
> --- a/dtprobed/Build
> +++ b/dtprobed/Build
> @@ -57,6 +57,7 @@ install::
>  	mkdir -p $(INSTSBINDIR)
>  	$(call describe-install-target,$(INSTSBINDIR),dtprobed)
>  	install -m 755 $(objdir)/dtprobed $(INSTSBINDIR)
> +	mkdir -p $(INSTMANDIR)/man8
>  	$(call describe-install-target,$(INSTMANDIR),dtprobed.8)
>  	install -m 644 $(dtprobed_DIR)/dtprobed.8 $(INSTMANDIR)/man8
>  	mkdir -p $(INSTUDEVDIR)
> 
> base-commit: 33bf8650bcfef147d464e8eecb66d552313f84b8
> -- 
> 2.46.0.278.g36e3a12567
> 

      reply	other threads:[~2024-11-05 19:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-31 17:40 [PATCH] build: mkdir man directories before installing to them Nick Alcock
2024-11-05 19:32 ` Kris Van Hees [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZypysvRLq1jLnnft@oracle.com \
    --to=kris.van.hees@oracle.com \
    --cc=dtrace-devel@oss.oracle.com \
    --cc=dtrace@lists.linux.dev \
    --cc=nick.alcock@oracle.com \
    --cc=sam@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox