public inbox for dtrace@lists.linux.dev
 help / color / mirror / Atom feed
From: Kris Van Hees <kris.van.hees@oracle.com>
To: Nick Alcock <nick.alcock@oracle.com>
Cc: Kris Van Hees <kris.van.hees@oracle.com>,
	dtrace@lists.linux.dev, dtrace-devel@oss.oracle.com
Subject: Re: [PATCH 1/3] spec: add dtrace.pc to filelist
Date: Mon, 11 Nov 2024 12:18:21 -0500	[thread overview]
Message-ID: <ZzI8XV+quXXPzwBR@oracle.com> (raw)
In-Reply-To: <87ttcd4vbr.fsf@esperi.org.uk>

On Mon, Nov 11, 2024 at 03:57:28PM +0000, Nick Alcock wrote:
> On 11 Nov 2024, Kris Van Hees uttered the following:
> 
> > Commit 52a18d35 "build: add a pkg-config file for dtrace consumers: use it"
> > added a dtrace.pc file but failed to add it to the dtrace.spec as well.
> > 
> > Signed-off-by: Kris Van Hees <kris.van.hees@oracle.com>
> 
> Wrong package: it's a consumer .pc so it should be in -devel.
> 
> (See the patch I just sent when I woke up before, uh, reading any mail.)

But dtrace.pc is the pkgconfig file that specifies where dtrace itself is
located.  I honestly would expect that to be part of the main package since
other tools that need dtrace for something would then be able to use pkgconfig
to find dtrace, etc.  Why else would we put the location of the dtrace
executble itself in there?  Without installing -devel you don't get to find
out where dtrace resides, but with -devel installed suddenly that becomes
something relevant?

  reply	other threads:[~2024-11-11 17:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-11  4:10 [PATCH 1/3] spec: add dtrace.pc to filelist Kris Van Hees
2024-11-11 15:57 ` Nick Alcock
2024-11-11 17:18   ` Kris Van Hees [this message]
2024-11-11 18:32     ` Nick Alcock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZzI8XV+quXXPzwBR@oracle.com \
    --to=kris.van.hees@oracle.com \
    --cc=dtrace-devel@oss.oracle.com \
    --cc=dtrace@lists.linux.dev \
    --cc=nick.alcock@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox