Re: [DTrace-devel] [PATCH] test/utils: add more reliable "get remote address" approach

Eugene Loh
2025-07-03T17:48:34Z

Reviewed-by: Eugene Loh <eugene.loh@oracle.com>

I confess I don't understand all the details, but it seems like a nice
improvement.  Thanks.

I tested and it looks good (modulo the OL8 UEK6 issue mentioned in the
patch 3/4 feedback).

I think you need to update Copyright years in the modified files. And...

On 7/3/25 07:33, Alan Maguire via DTrace-devel wrote:

> The current approach of looking for remote addresses
> is brittle and fails in many environments; it checks the
> default route gateway and looks for open ports in the TCP
> case.
>
> We can however achieve the same goal reliably by creating
> a network namespace on the system and configuring either
> IPv4 or IPv6 addresses on the namespaced and local veth
> interfaces that support communication between namespaces.
> If a tcp port is required start sshd to listen on that port.

Maybe a comma after "required"?

> Teardown is managed in runtest.sh as signal handling for
> timeouts within the test scripts is not working; a trap
> function does not trigger for TERM.

I'm having trouble parsing the text before the semicolon.  I think I
understand it, but cannot seem to figure out the grammar.