From: Kris Van Hees <kris.van.hees@oracle.com>
To: Nick Alcock <nick.alcock@oracle.com>
Cc: Kris Van Hees <kris.van.hees@oracle.com>,
dtrace@lists.linux.dev, dtrace-devel@oss.oracle.com
Subject: Re: [PATCH] Free the DIFO for a probe once it is loaded
Date: Fri, 25 Jul 2025 14:55:45 -0400 [thread overview]
Message-ID: <aIPTMUiUEPAe2wwF@oracle.com> (raw)
In-Reply-To: <87o6t83yiw.fsf@esperi.org.uk>
On Fri, Jul 25, 2025 at 07:39:51PM +0100, Nick Alcock wrote:
> On 25 Jul 2025, Kris Van Hees verbalised:
>
> > When a lot of probes are being probed, keeping all DIFO around consumes
> > a lot of memory. Once the BPF program is loaded, the DIFO can be freed.
>
> DIFO? BPFO, surely :)
>
> ... the attached patch only seems to free anything new on failure, not
> on after-loading.
Oops, yes, will fix and send out a new one.
> > +fail:
> > + dt_difo_free(dtp, prp->difo);
> > + prp->difo = NULL;
> > + return -1;
> [...]
> > +fail:
> > + dt_difo_free(dtp, prp->difo);
> > + prp->difo = NULL;
> > + return 0; // FIXME in dt_bpf_make_progs() this is a fatal error; should we do the same here?
prev parent reply other threads:[~2025-07-25 18:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-25 4:01 [PATCH] Free the DIFO for a probe once it is loaded Kris Van Hees
2025-07-25 18:39 ` Nick Alcock
2025-07-25 18:55 ` Kris Van Hees [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aIPTMUiUEPAe2wwF@oracle.com \
--to=kris.van.hees@oracle.com \
--cc=dtrace-devel@oss.oracle.com \
--cc=dtrace@lists.linux.dev \
--cc=nick.alcock@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox