public inbox for dtrace@lists.linux.dev
 help / color / mirror / Atom feed
From: Kris Van Hees <kris.van.hees@oracle.com>
To: Nick Alcock <nick.alcock@oracle.com>
Cc: eugene.loh@oracle.com, dtrace@lists.linux.dev,
	dtrace-devel@oss.oracle.com
Subject: Re: [DTrace-devel] [PATCH v2] test: Wait for output to flush out in enable_pid
Date: Tue, 29 Jul 2025 10:13:20 -0400	[thread overview]
Message-ID: <aIjXAIS6pP+51BMI@oracle.com> (raw)
In-Reply-To: <877c005or4.fsf@esperi.org.uk>

On Tue, Jul 22, 2025 at 02:38:55PM +0100, Nick Alcock via DTrace-devel wrote:
> On 28 Jun 2025, eugene loh said:
> 
> > From: Eugene Loh <eugene.loh@oracle.com>
> >
> > Our luck with this test has been quite good, but it sometimes fails
> > to show its last lines of output.  That is, we send a USR1 to the
> > trigger processes to set off the final output and we immediately
> > cat the output files.  If there is any delay in handling the signal,
> > the last output will be missing.
> >
> > Have the processes terminate themselves when their last output is
> > flushed; then wait for those processes.  Also, skip testing altogether if
> > there is only a single processor to run the two, hard-spinning processes.
> 
> Yeah, much better design.
> 
> > Signed-off-by: Eugene Loh <eugene.loh@oracle.com>
> 
> Reviewed-by: Nick Alcock <nick.alcock@oracle.com>

Unfortunately, without this patch the test PASSes for me.
With this patch it FAILs with a time out.

Not sure what is going on, but this needs investigation before the patch can
go in.

  reply	other threads:[~2025-07-29 14:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-28 22:30 [PATCH v2] test: Wait for output to flush out in enable_pid eugene.loh
2025-07-22 13:38 ` Nick Alcock
2025-07-29 14:13   ` Kris Van Hees [this message]
2025-07-29 15:19     ` [DTrace-devel] " Kris Van Hees
2025-07-30 14:18 ` Kris Van Hees
2025-07-30 14:26   ` [DTrace-devel] " Kris Van Hees
2025-07-30 22:03     ` Eugene Loh
2025-07-30 22:39       ` Kris Van Hees
2025-07-31  0:17         ` Kris Van Hees

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aIjXAIS6pP+51BMI@oracle.com \
    --to=kris.van.hees@oracle.com \
    --cc=dtrace-devel@oss.oracle.com \
    --cc=dtrace@lists.linux.dev \
    --cc=eugene.loh@oracle.com \
    --cc=nick.alcock@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox