Re: [DTrace-devel] [PATCH v2] test: Wait for output to flush out in enable_pid

Kris Van Hees
2025-07-29T15:19:18Z

On Tue, Jul 29, 2025 at 10:13:20AM -0400, Kris Van Hees wrote:
> On Tue, Jul 22, 2025 at 02:38:55PM +0100, Nick Alcock via DTrace-devel wrote:
> > On 28 Jun 2025, eugene loh said:
> >
> > > From: Eugene Loh <eugene.loh@oracle.com>
> > >
> > > Our luck with this test has been quite good, but it sometimes fails
> > > to show its last lines of output. That is, we send a USR1 to the
> > > trigger processes to set off the final output and we immediately
> > > cat the output files. If there is any delay in handling the signal,
> > > the last output will be missing.
> > >
> > > Have the processes terminate themselves when their last output is
> > > flushed; then wait for those processes. Also, skip testing altogether if
> > > there is only a single processor to run the two, hard-spinning processes.
> >
> > Yeah, much better design.
> >
> > > Signed-off-by: Eugene Loh <eugene.loh@oracle.com>
> >
> > Reviewed-by: Nick Alcock <nick.alcock@oracle.com>
>
> Unfortunately, without this patch the test PASSes for me.
> With this patch it FAILs with a time out.
>
> Not sure what is going on, but this needs investigation before the patch can
> go in.

Actually, I am a bit off here... it is still intermittent for me on Debian
and OL9. So I am not sure what else is going wrong.