From: Kris Van Hees <kris.van.hees@oracle.com>
To: Nick Alcock <nick.alcock@oracle.com>
Cc: eugene.loh@oracle.com, dtrace-devel@oss.oracle.com,
dtrace@lists.linux.dev
Subject: Re: [DTrace-devel] [PATCH 1.5/3] Remove unused map-of-maps functions
Date: Thu, 31 Jul 2025 12:13:48 -0400 [thread overview]
Message-ID: <aIuWPHzoQ0hvpz3Y@oracle.com> (raw)
In-Reply-To: <87ikjsmei7.fsf@esperi.org.uk>
On Wed, Jul 16, 2025 at 02:50:08PM +0100, Nick Alcock wrote:
> On 1 May 2025, eugene loh outgrape:
>
> > From: Eugene Loh <eugene.loh@oracle.com>
> >
> > Signed-off-by: Eugene Loh <eugene.loh@oracle.com>
>
> Reviewed-by: Nick Alcock <nick.alcock@oracle.com>
While in general I am all for removing unused function, I would actually
prefer to keep these because they are part of our BPF library and likely
to be of use in the future. Yes, we could always revert this, but it is
probably more likely that we would end up re-implementing them because
we forgot they ever existed. Since we implement our own library to
interact with the BPF subsystem, having some extra functions around for
now for functionality that isn't immediately trivial to implement when
you deal with inner maps for the first time, can be useful.
prev parent reply other threads:[~2025-07-31 16:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-01 18:37 [PATCH 1.5/3] Remove unused map-of-maps functions eugene.loh
2025-07-16 13:50 ` [DTrace-devel] " Nick Alcock
2025-07-31 16:13 ` Kris Van Hees [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aIuWPHzoQ0hvpz3Y@oracle.com \
--to=kris.van.hees@oracle.com \
--cc=dtrace-devel@oss.oracle.com \
--cc=dtrace@lists.linux.dev \
--cc=eugene.loh@oracle.com \
--cc=nick.alcock@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox