public inbox for dtrace@lists.linux.dev
 help / color / mirror / Atom feed
* [PATCH 1/6] Convert ip6_finish_output to rawfbt
@ 2025-09-05 17:07 eugene.loh
  2025-09-05 17:07 ` [PATCH] test: Update DTrace version string eugene.loh
  2025-09-05 17:08 ` [PATCH 1/6] Convert ip6_finish_output to rawfbt Eugene Loh
  0 siblings, 2 replies; 4+ messages in thread
From: eugene.loh @ 2025-09-05 17:07 UTC (permalink / raw)
  To: dtrace, dtrace-devel

From: Eugene Loh <eugene.loh@oracle.com>

With commit fe2101e55 ("fbt: implement based on fentry/fexit probes")
test/unittest/ip/tst.ipv6localicmp.sh started to fail.  The problem
appears to be that fbt::ip6_finish_output:entry, which is needed for
ip:::send, does not fire.

Use rawfbt for this probe to revert back to kprobes in this case.

Other fbt probes may also be impacted, but this case showed up in testing.

Signed-off-by: Eugene Loh <eugene.loh@oracle.com>
Reviewed-by: Alan Maguire <alan.maguire@oracle.com>
---
 libdtrace/dt_prov_ip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libdtrace/dt_prov_ip.c b/libdtrace/dt_prov_ip.c
index e0919806..5384346b 100644
--- a/libdtrace/dt_prov_ip.c
+++ b/libdtrace/dt_prov_ip.c
@@ -25,7 +25,7 @@ static probe_dep_t	probes[] = {
 	{ "send",
 	  DTRACE_PROBESPEC_NAME,	"fbt::ip_finish_output:entry" },
 	{ "send",
-	  DTRACE_PROBESPEC_NAME,	"fbt::ip6_finish_output:entry" },
+	  DTRACE_PROBESPEC_NAME,	"rawfbt::ip6_finish_output:entry" },
 	{ NULL, }
 };
 
-- 
2.47.3


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] test: Update DTrace version string
  2025-09-05 17:07 [PATCH 1/6] Convert ip6_finish_output to rawfbt eugene.loh
@ 2025-09-05 17:07 ` eugene.loh
  2025-09-11 20:49   ` [DTrace-devel] " Kris Van Hees
  2025-09-05 17:08 ` [PATCH 1/6] Convert ip6_finish_output to rawfbt Eugene Loh
  1 sibling, 1 reply; 4+ messages in thread
From: eugene.loh @ 2025-09-05 17:07 UTC (permalink / raw)
  To: dtrace, dtrace-devel

From: Eugene Loh <eugene.loh@oracle.com>

Commit a48a76472 ("version: fix DTrace version string") changed
the DTrace version string without addressing associated testing.

Update the test suite to match the version string change.

Signed-off-by: Eugene Loh <eugene.loh@oracle.com>
---
 test/unittest/dtrace-util/tst.APIVersion.r | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/unittest/dtrace-util/tst.APIVersion.r b/test/unittest/dtrace-util/tst.APIVersion.r
index 0d88b694e..72d03e71c 100644
--- a/test/unittest/dtrace-util/tst.APIVersion.r
+++ b/test/unittest/dtrace-util/tst.APIVersion.r
@@ -1 +1 @@
-dtrace: Oracle D x.y.z
+dtrace: D x.y.z
-- 
2.47.3


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/6] Convert ip6_finish_output to rawfbt
  2025-09-05 17:07 [PATCH 1/6] Convert ip6_finish_output to rawfbt eugene.loh
  2025-09-05 17:07 ` [PATCH] test: Update DTrace version string eugene.loh
@ 2025-09-05 17:08 ` Eugene Loh
  1 sibling, 0 replies; 4+ messages in thread
From: Eugene Loh @ 2025-09-05 17:08 UTC (permalink / raw)
  To: dtrace, dtrace-devel

Oops.  Ignore this.  It's already been reviewed and was accidentally 
sent out again.

On 9/5/25 13:07, eugene.loh@oracle.com wrote:
> From: Eugene Loh <eugene.loh@oracle.com>
>
> With commit fe2101e55 ("fbt: implement based on fentry/fexit probes")
> test/unittest/ip/tst.ipv6localicmp.sh started to fail.  The problem
> appears to be that fbt::ip6_finish_output:entry, which is needed for
> ip:::send, does not fire.
>
> Use rawfbt for this probe to revert back to kprobes in this case.
>
> Other fbt probes may also be impacted, but this case showed up in testing.
>
> Signed-off-by: Eugene Loh <eugene.loh@oracle.com>
> Reviewed-by: Alan Maguire <alan.maguire@oracle.com>
> ---
>   libdtrace/dt_prov_ip.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libdtrace/dt_prov_ip.c b/libdtrace/dt_prov_ip.c
> index e0919806..5384346b 100644
> --- a/libdtrace/dt_prov_ip.c
> +++ b/libdtrace/dt_prov_ip.c
> @@ -25,7 +25,7 @@ static probe_dep_t	probes[] = {
>   	{ "send",
>   	  DTRACE_PROBESPEC_NAME,	"fbt::ip_finish_output:entry" },
>   	{ "send",
> -	  DTRACE_PROBESPEC_NAME,	"fbt::ip6_finish_output:entry" },
> +	  DTRACE_PROBESPEC_NAME,	"rawfbt::ip6_finish_output:entry" },
>   	{ NULL, }
>   };
>   

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [DTrace-devel] [PATCH] test: Update DTrace version string
  2025-09-05 17:07 ` [PATCH] test: Update DTrace version string eugene.loh
@ 2025-09-11 20:49   ` Kris Van Hees
  0 siblings, 0 replies; 4+ messages in thread
From: Kris Van Hees @ 2025-09-11 20:49 UTC (permalink / raw)
  To: eugene.loh; +Cc: dtrace, dtrace-devel

Reviewed-by: Kris Van Hees <kris.van.hees@oracle.com>

On Fri, Sep 05, 2025 at 01:07:15PM -0400, eugene.loh--- via DTrace-devel wrote:
> From: Eugene Loh <eugene.loh@oracle.com>
> 
> Commit a48a76472 ("version: fix DTrace version string") changed
> the DTrace version string without addressing associated testing.
> 
> Update the test suite to match the version string change.
> 
> Signed-off-by: Eugene Loh <eugene.loh@oracle.com>
> ---
>  test/unittest/dtrace-util/tst.APIVersion.r | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/test/unittest/dtrace-util/tst.APIVersion.r b/test/unittest/dtrace-util/tst.APIVersion.r
> index 0d88b694e..72d03e71c 100644
> --- a/test/unittest/dtrace-util/tst.APIVersion.r
> +++ b/test/unittest/dtrace-util/tst.APIVersion.r
> @@ -1 +1 @@
> -dtrace: Oracle D x.y.z
> +dtrace: D x.y.z
> -- 
> 2.47.3
> 
> 
> _______________________________________________
> DTrace-devel mailing list
> DTrace-devel@oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/dtrace-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-09-11 20:49 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-05 17:07 [PATCH 1/6] Convert ip6_finish_output to rawfbt eugene.loh
2025-09-05 17:07 ` [PATCH] test: Update DTrace version string eugene.loh
2025-09-11 20:49   ` [DTrace-devel] " Kris Van Hees
2025-09-05 17:08 ` [PATCH 1/6] Convert ip6_finish_output to rawfbt Eugene Loh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox