From: Kris Van Hees <kris.van.hees@oracle.com>
To: Eugene Loh <eugene.loh@oracle.com>
Cc: Kris Van Hees <kris.van.hees@oracle.com>,
dtrace@lists.linux.dev, dtrace-devel@oss.oracle.com
Subject: Re: [PATCH v2] trace: print alloca pointers as actual pointer values
Date: Fri, 12 Sep 2025 20:50:15 -0400 [thread overview]
Message-ID: <aMS/x6mbD+N17I1H@oracle.com> (raw)
In-Reply-To: <e464c8fb-2f74-a3e8-4fa9-c9074c0e661a@oracle.com>
On Fri, Sep 12, 2025 at 08:36:19PM -0400, Eugene Loh wrote:
> Similar comments to v1:
>
> On 9/12/25 00:16, Kris Van Hees wrote:
> > Because alloca pointers are stored internally as ofssets into the
>
> Again, s/ofssets/offsets/.
>
> > scratchmem area, they were printed as small integers. They are
> > now printed as actual pointer values into kernel space.
>
> And again test failures. This time, not with the new test, but as you say,
> "Ah, tehe joy of fixing one problem only to uncover another." So this time:
>
> test/unittest/funcs/alloca/tst.alloca-funcs.d: FAIL: expected
> results differ.
> Diff against expected:
> a/b
> -8b11/b/b3a/b//baba
> +18446671313727729520b11/b/b3a/b//baba
>
> Here, "8" has become "18446671313727729520". So, need some .r change (and
> some .r.p magic and possibly .d tweak).
This is resolved by the other patch about subtracting pointers. With both
patches, this failure is no longer.
> test/unittest/funcs/alloca/tst.string-alloca.d: FAIL: expected
> results differ.
> Diff against expected:
> -abc
> +
>
> Here, simply a bug?
Hm... This passed on my end somehow. Let me look (perhaps I forgot to include
a change when I prepared the v2).
prev parent reply other threads:[~2025-09-13 0:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-12 4:16 [PATCH v2] trace: print alloca pointers as actual pointer values Kris Van Hees
2025-09-13 0:36 ` Eugene Loh
2025-09-13 0:50 ` Kris Van Hees [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aMS/x6mbD+N17I1H@oracle.com \
--to=kris.van.hees@oracle.com \
--cc=dtrace-devel@oss.oracle.com \
--cc=dtrace@lists.linux.dev \
--cc=eugene.loh@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox