From: Kris Van Hees <kris.van.hees@oracle.com>
To: eugene.loh@oracle.com
Cc: dtrace@lists.linux.dev, dtrace-devel@oss.oracle.com
Subject: Re: [PATCH] test: Add trigger for more predictable run time
Date: Tue, 16 Sep 2025 22:48:52 -0400 [thread overview]
Message-ID: <aMohlKuLsP1+xrEV@oracle.com> (raw)
In-Reply-To: <20250916225506.7929-1-eugene.loh@oracle.com>
On Tue, Sep 16, 2025 at 06:55:06PM -0400, eugene.loh@oracle.com wrote:
> From: Eugene Loh <eugene.loh@oracle.com>
>
> The test had no trigger and so waited haphazardly for the write:entry
> probe to fire. This typically worked, but led to variable run times
> and even, though rarely, a test timeout and failure.
>
> Add a trigger for more reproducible and typically shorter run times.
>
> Signed-off-by: Eugene Loh <eugene.loh@oracle.com>
Reviewed-by: Kris Van Hees <kris.van.hees@oracle.com>
> ---
> test/unittest/error/tst.argv-corruption-by-error.d | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/test/unittest/error/tst.argv-corruption-by-error.d b/test/unittest/error/tst.argv-corruption-by-error.d
> index 6fd1834e1..1fdd89858 100644
> --- a/test/unittest/error/tst.argv-corruption-by-error.d
> +++ b/test/unittest/error/tst.argv-corruption-by-error.d
> @@ -1,6 +1,6 @@
> /*
> * Oracle Linux DTrace.
> - * Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved.
> + * Copyright (c) 2024, 2025, Oracle and/or its affiliates. All rights reserved.
> * Licensed under the Universal Permissive License v 1.0 as shown at
> * http://oss.oracle.com/licenses/upl.
> */
> @@ -13,6 +13,7 @@
> *
> * SECTION: dtrace Provider
> */
> +/* @@trigger: periodic_output */
>
> #pragma D option quiet
>
> --
> 2.47.3
>
prev parent reply other threads:[~2025-09-17 2:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-16 22:55 [PATCH] test: Add trigger for more predictable run time eugene.loh
2025-09-17 2:48 ` Kris Van Hees [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aMohlKuLsP1+xrEV@oracle.com \
--to=kris.van.hees@oracle.com \
--cc=dtrace-devel@oss.oracle.com \
--cc=dtrace@lists.linux.dev \
--cc=eugene.loh@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox