[PATCH] test: Add trigger for more predictable run time

[PATCH] test: Add trigger for more predictable run time

[eugene.loh]

From: Eugene Loh <eugene.loh@oracle.com>

The test had no trigger and so waited haphazardly for the write:entry
probe to fire.  This typically worked, but led to variable run times
and even, though rarely, a test timeout and failure.

Add a trigger for more reproducible and typically shorter run times.

Signed-off-by: Eugene Loh <eugene.loh@oracle.com>
---
 test/unittest/error/tst.argv-corruption-by-error.d | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/test/unittest/error/tst.argv-corruption-by-error.d b/test/unittest/error/tst.argv-corruption-by-error.d
index 6fd1834e1..1fdd89858 100644
--- a/test/unittest/error/tst.argv-corruption-by-error.d
+++ b/test/unittest/error/tst.argv-corruption-by-error.d
@@ -1,6 +1,6 @@
 /*
  * Oracle Linux DTrace.
- * Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2024, 2025, Oracle and/or its affiliates. All rights reserved.
  * Licensed under the Universal Permissive License v 1.0 as shown at
  * http://oss.oracle.com/licenses/upl.
  */
@@ -13,6 +13,7 @@
  *
  * SECTION: dtrace Provider
  */
+/* @@trigger: periodic_output */
 
 #pragma D option quiet
 
-- 
2.47.3

Re: [PATCH] test: Add trigger for more predictable run time

[Kris Van Hees]

On Tue, Sep 16, 2025 at 06:55:06PM -0400, eugene.loh@oracle.com wrote:
> From: Eugene Loh <eugene.loh@oracle.com>
> 
> The test had no trigger and so waited haphazardly for the write:entry
> probe to fire.  This typically worked, but led to variable run times
> and even, though rarely, a test timeout and failure.
> 
> Add a trigger for more reproducible and typically shorter run times.
> 
> Signed-off-by: Eugene Loh <eugene.loh@oracle.com>

Reviewed-by: Kris Van Hees <kris.van.hees@oracle.com>

> ---
>  test/unittest/error/tst.argv-corruption-by-error.d | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/test/unittest/error/tst.argv-corruption-by-error.d b/test/unittest/error/tst.argv-corruption-by-error.d
> index 6fd1834e1..1fdd89858 100644
> --- a/test/unittest/error/tst.argv-corruption-by-error.d
> +++ b/test/unittest/error/tst.argv-corruption-by-error.d
> @@ -1,6 +1,6 @@
>  /*
>   * Oracle Linux DTrace.
> - * Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved.
> + * Copyright (c) 2024, 2025, Oracle and/or its affiliates. All rights reserved.
>   * Licensed under the Universal Permissive License v 1.0 as shown at
>   * http://oss.oracle.com/licenses/upl.
>   */
> @@ -13,6 +13,7 @@
>   *
>   * SECTION: dtrace Provider
>   */
> +/* @@trigger: periodic_output */
>  
>  #pragma D option quiet
>  
> -- 
> 2.47.3
>