public inbox for dtrace@lists.linux.dev
 help / color / mirror / Atom feed
From: Kris Van Hees <kris.van.hees@oracle.com>
To: eugene.loh@oracle.com
Cc: dtrace@lists.linux.dev, dtrace-devel@oss.oracle.com
Subject: Re: [PATCH 2/5] test: Adjust skip file for lockmem problem
Date: Thu, 2 Oct 2025 23:52:58 -0400	[thread overview]
Message-ID: <aN9Imhcv4KweENK1@oracle.com> (raw)
In-Reply-To: <20251001062418.6902-2-eugene.loh@oracle.com>

On Wed, Oct 01, 2025 at 02:24:15AM -0400, eugene.loh@oracle.com wrote:
> From: Eugene Loh <eugene.loh@oracle.com>
> 
> dtrace seems to work for recent kernel versions even when lockmem
> is set too low.  The .x skip files for the lockmem tests say:
>   - UEKR6 (5.4.17) we should test
>   - UEKR7 (5.15.0) we should skip
> and so it starts skipping with 5.15.
> 
> Apparently, however, lockmem does not impede dtrace on RHCK 5.14
> either.
> 
> So, tweak the skip file to skip on 5.14 as well.

But this seems to make the assumption that RHCK 5.14 is the same as upstream
5.14, which I highly doubt to be the case.  So, we should not change this
unless it has been verified that upstream 5.14 indeed also does not impede
dtrace when lockmem is set too low.

> Signed-off-by: Eugene Loh <eugene.loh@oracle.com>
> ---
>  test/unittest/misc/tst.lockmem-envvar.x | 4 ++--
>  test/unittest/misc/tst.lockmem-x.x      | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/test/unittest/misc/tst.lockmem-envvar.x b/test/unittest/misc/tst.lockmem-envvar.x
> index a779416b9..494ac67fa 100755
> --- a/test/unittest/misc/tst.lockmem-envvar.x
> +++ b/test/unittest/misc/tst.lockmem-envvar.x
> @@ -5,12 +5,12 @@ read MAJOR MINOR <<< `uname -r | grep -Eo '^[0-9]+\.[0-9]+' | tr '.' ' '`
>  if [ $MAJOR -lt 5 ]; then
>          exit 0
>  fi
> -if [ $MAJOR -eq 5 -a $MINOR -lt 15 ]; then
> +if [ $MAJOR -eq 5 -a $MINOR -lt 14 ]; then
>          exit 0
>  fi
>  
>  # Somehow, UEKR6 (5.4.17) has problems with the the locked-memory limit,
> -# but UEKR7 (5.15.0) does not
> +# but UEKR7 (5.15.0) and RHCK 5.14 do not
>  
>  echo "no locked-memory limit on newer kernels?"
>  exit 1
> diff --git a/test/unittest/misc/tst.lockmem-x.x b/test/unittest/misc/tst.lockmem-x.x
> index a779416b9..494ac67fa 100755
> --- a/test/unittest/misc/tst.lockmem-x.x
> +++ b/test/unittest/misc/tst.lockmem-x.x
> @@ -5,12 +5,12 @@ read MAJOR MINOR <<< `uname -r | grep -Eo '^[0-9]+\.[0-9]+' | tr '.' ' '`
>  if [ $MAJOR -lt 5 ]; then
>          exit 0
>  fi
> -if [ $MAJOR -eq 5 -a $MINOR -lt 15 ]; then
> +if [ $MAJOR -eq 5 -a $MINOR -lt 14 ]; then
>          exit 0
>  fi
>  
>  # Somehow, UEKR6 (5.4.17) has problems with the the locked-memory limit,
> -# but UEKR7 (5.15.0) does not
> +# but UEKR7 (5.15.0) and RHCK 5.14 do not
>  
>  echo "no locked-memory limit on newer kernels?"
>  exit 1
> -- 
> 2.47.3
> 

  reply	other threads:[~2025-10-03  3:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-01  6:24 [PATCH 1/5] test: Use a more ubiquitous probe for return()-action tests eugene.loh
2025-10-01  6:24 ` [PATCH 2/5] test: Adjust skip file for lockmem problem eugene.loh
2025-10-03  3:52   ` Kris Van Hees [this message]
2025-10-01  6:24 ` [PATCH 3/5] test: Fix some ustackdepth tests eugene.loh
2025-10-03  4:07   ` Kris Van Hees
2025-10-09 16:29     ` Kris Van Hees
2025-10-09 21:11       ` Eugene Loh
2025-10-01  6:24 ` [PATCH 4/5] test: Fix antiquated reference to dtrace_ustackdepth_max eugene.loh
2025-10-03  3:56   ` Kris Van Hees
2025-10-01  6:24 ` [PATCH 5/5] test: Remove antiquated special case for aarch64 eugene.loh
2025-10-03  3:55   ` Kris Van Hees
2025-10-03  3:50 ` [PATCH 1/5] test: Use a more ubiquitous probe for return()-action tests Kris Van Hees

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aN9Imhcv4KweENK1@oracle.com \
    --to=kris.van.hees@oracle.com \
    --cc=dtrace-devel@oss.oracle.com \
    --cc=dtrace@lists.linux.dev \
    --cc=eugene.loh@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox