public inbox for dtrace@lists.linux.dev
 help / color / mirror / Atom feed
From: Kris Van Hees <kris.van.hees@oracle.com>
To: Nick Alcock <nick.alcock@oracle.com>
Cc: dtrace@lists.linux.dev, dtrace-devel@oss.oracle.com
Subject: Re: [PATCH v2 1/5] test: fbt return0: work on quiet systems
Date: Wed, 8 Oct 2025 12:15:06 -0400	[thread overview]
Message-ID: <aOaOCtgFER7kUTdq@oracle.com> (raw)
In-Reply-To: <20251008111642.422592-1-nick.alcock@oracle.com>

On Wed, Oct 08, 2025 at 12:16:42PM +0100, Nick Alcock wrote:
> These two tests probe on sys_poll and just hope something calls it.
> On sufficiently quiet systems, nothing does.
> 
> Use hrtimer_nanosleep instead.
> 
> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>

Reviewed-by: Kris Van Hees <kris.van.hees@oracle.com>

> ---
>  test/unittest/fbtprovider/tst.return0.d      | 4 +++-
>  test/unittest/fbtprovider/tst.return0.r      | 2 +-
>  test/unittest/providers/rawfbt/tst.return0.d | 4 +++-
>  test/unittest/providers/rawfbt/tst.return0.r | 2 +-
>  4 files changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/test/unittest/fbtprovider/tst.return0.d b/test/unittest/fbtprovider/tst.return0.d
> index 0b7091b320904..f06120a55e5d0 100644
> --- a/test/unittest/fbtprovider/tst.return0.d
> +++ b/test/unittest/fbtprovider/tst.return0.d
> @@ -11,10 +11,12 @@
>   * SECTION: FBT Provider/Probe arguments
>   */
>  
> +/* @@trigger: periodic_output */
> +
>  #pragma D option quiet
>  #pragma D option statusrate=10ms
>  
> -fbt::do_sys_poll:return
> +fbt:vmlinux:hrtimer_nanosleep:return
>  /arg1 == 0/
>  {
>  	printf("%s %x returned 0", probefunc, arg0);
> diff --git a/test/unittest/fbtprovider/tst.return0.r b/test/unittest/fbtprovider/tst.return0.r
> index 53308c30f27ab..e4065e20062e0 100644
> --- a/test/unittest/fbtprovider/tst.return0.r
> +++ b/test/unittest/fbtprovider/tst.return0.r
> @@ -1 +1 @@
> -do_sys_poll ffffffffffffffff returned 0
> +hrtimer_nanosleep ffffffffffffffff returned 0
> diff --git a/test/unittest/providers/rawfbt/tst.return0.d b/test/unittest/providers/rawfbt/tst.return0.d
> index 0146d684f1033..3a39740071c49 100644
> --- a/test/unittest/providers/rawfbt/tst.return0.d
> +++ b/test/unittest/providers/rawfbt/tst.return0.d
> @@ -9,10 +9,12 @@
>   * ASSERTION: simple rawfbt provider arg0 and probefunc print test.
>   */
>  
> +/* @@trigger: periodic_output */
> +
>  #pragma D option quiet
>  #pragma D option statusrate=10ms
>  
> -rawfbt::do_sys_poll:return
> +fbt:vmlinux:hrtimer_nanosleep:return
>  /arg1 == 0/
>  {
>  	printf("%s %x returned 0", probefunc, arg0);
> diff --git a/test/unittest/providers/rawfbt/tst.return0.r b/test/unittest/providers/rawfbt/tst.return0.r
> index 53308c30f27ab..e4065e20062e0 100644
> --- a/test/unittest/providers/rawfbt/tst.return0.r
> +++ b/test/unittest/providers/rawfbt/tst.return0.r
> @@ -1 +1 @@
> -do_sys_poll ffffffffffffffff returned 0
> +hrtimer_nanosleep ffffffffffffffff returned 0
> 
> base-commit: 877fcdeb25b370be182d51f27fb4bd8e4f739fb1
> -- 
> 2.51.0.284.g117bcb8de7
> 

      reply	other threads:[~2025-10-08 16:15 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-06 15:28 [PATCH 1/5] test: fbt return0: work on quiet systems Nick Alcock
2025-10-06 15:28 ` [PATCH 2/5] test: nfs: don't require a locking daemon Nick Alcock
2025-10-06 16:11   ` Kris Van Hees
2025-10-06 15:28 ` [PATCH 3/5] test: preprocessor: work on GCC 16 Nick Alcock
2025-10-07 15:08   ` Kris Van Hees
2025-10-06 15:28 ` [PATCH 4/5] test: tid_pid: don't assume the type of pthread_t Nick Alcock
2025-10-06 16:13   ` Kris Van Hees
2025-10-06 15:28 ` [PATCH 5/5] test: dupstruct: fix extra duplicate identifier case Nick Alcock
2025-10-06 16:14   ` Kris Van Hees
2025-10-06 16:09 ` [PATCH 1/5] test: fbt return0: work on quiet systems Kris Van Hees
2025-10-07 15:36   ` Nick Alcock
2025-10-08 11:16   ` [PATCH v2 " Nick Alcock
2025-10-08 16:15     ` Kris Van Hees [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aOaOCtgFER7kUTdq@oracle.com \
    --to=kris.van.hees@oracle.com \
    --cc=dtrace-devel@oss.oracle.com \
    --cc=dtrace@lists.linux.dev \
    --cc=nick.alcock@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox