public inbox for dtrace@lists.linux.dev
 help / color / mirror / Atom feed
From: Kris Van Hees <kris.van.hees@oracle.com>
To: eugene.loh@oracle.com
Cc: dtrace@lists.linux.dev, dtrace-devel@oss.oracle.com
Subject: Re: [DTrace-devel] [PATCH] test: Modify fbtsafety tests that use vtimestamp unnecessarily
Date: Wed, 8 Oct 2025 12:37:54 -0400	[thread overview]
Message-ID: <aOaTYrHmJky0rOAS@oracle.com> (raw)
In-Reply-To: <20251007225543.31749-1-eugene.loh@oracle.com>

On Tue, Oct 07, 2025 at 06:55:43PM -0400, eugene.loh--- via DTrace-devel wrote:
> From: Eugene Loh <eugene.loh@oracle.com>
> 
> Currently, we do not implement vtimestamp.
> 
> Signed-off-by: Eugene Loh <eugene.loh@oracle.com>

Reviewed-by: Kris Van Hees <kris.van.hees@oracle.com>

> ---
>  test/stress/fbtsafety/tst.index.d             | 6 +++---
>  test/stress/fbtsafety/tst.strjoin.d           | 4 ++--
>  test/stress/fbtsafety/tst.strstr.d            | 4 ++--
>  test/stress/fbtsafety/tst.strtok.d            | 4 ++--
>  test/stress/fbtsafety/tst.substr.d            | 6 +++---
>  test/unittest/variables/bvar/tst.vtimestamp.d | 2 +-
>  6 files changed, 13 insertions(+), 13 deletions(-)
> 
> diff --git a/test/stress/fbtsafety/tst.index.d b/test/stress/fbtsafety/tst.index.d
> index e30b94c0a..930d074ab 100644
> --- a/test/stress/fbtsafety/tst.index.d
> +++ b/test/stress/fbtsafety/tst.index.d
> @@ -1,6 +1,6 @@
>  /*
>   * Oracle Linux DTrace.
> - * Copyright (c) 2006, 2020, Oracle and/or its affiliates. All rights reserved.
> + * Copyright (c) 2006, 2025, Oracle and/or its affiliates. All rights reserved.
>   * Licensed under the Universal Permissive License v 1.0 as shown at
>   * http://oss.oracle.com/licenses/upl.
>   */
> @@ -17,13 +17,13 @@ fbt:::
>  fbt:::
>  /on/
>  {
> -	trace(index((char *)rand(), (char *)(rand() ^ vtimestamp)));
> +	trace(index((char *)rand(), (char *)(rand() ^ timestamp)));
>  }
>  
>  fbt:::
>  /on/
>  {
> -	trace(rindex((char *)rand(), (char *)(rand() ^ vtimestamp,
> +	trace(rindex((char *)rand(), (char *)(rand() ^ timestamp,
>  	    timestamp)));
>  }
>  
> diff --git a/test/stress/fbtsafety/tst.strjoin.d b/test/stress/fbtsafety/tst.strjoin.d
> index a22cc7943..1a9fbe733 100644
> --- a/test/stress/fbtsafety/tst.strjoin.d
> +++ b/test/stress/fbtsafety/tst.strjoin.d
> @@ -1,6 +1,6 @@
>  /*
>   * Oracle Linux DTrace.
> - * Copyright (c) 2006, 2020, Oracle and/or its affiliates. All rights reserved.
> + * Copyright (c) 2006, 2025, Oracle and/or its affiliates. All rights reserved.
>   * Licensed under the Universal Permissive License v 1.0 as shown at
>   * http://oss.oracle.com/licenses/upl.
>   */
> @@ -17,7 +17,7 @@ fbt:::
>  fbt:::
>  /on/
>  {
> -	trace(strjoin((char *)rand(), (char *)(rand() ^ vtimestamp)));
> +	trace(strjoin((char *)rand(), (char *)(rand() ^ timestamp)));
>  }
>  
>  fbt:::entry
> diff --git a/test/stress/fbtsafety/tst.strstr.d b/test/stress/fbtsafety/tst.strstr.d
> index 13f4a9245..15c1e15e8 100644
> --- a/test/stress/fbtsafety/tst.strstr.d
> +++ b/test/stress/fbtsafety/tst.strstr.d
> @@ -1,6 +1,6 @@
>  /*
>   * Oracle Linux DTrace.
> - * Copyright (c) 2006, 2020, Oracle and/or its affiliates. All rights reserved.
> + * Copyright (c) 2006, 2025, Oracle and/or its affiliates. All rights reserved.
>   * Licensed under the Universal Permissive License v 1.0 as shown at
>   * http://oss.oracle.com/licenses/upl.
>   */
> @@ -17,7 +17,7 @@ fbt:::
>  fbt:::
>  /on/
>  {
> -	trace(strstr((char *)rand(), (char *)(rand() ^ vtimestamp)));
> +	trace(strstr((char *)rand(), (char *)(rand() ^ timestamp)));
>  }
>  
>  fbt:::entry
> diff --git a/test/stress/fbtsafety/tst.strtok.d b/test/stress/fbtsafety/tst.strtok.d
> index bc0a707eb..edc2ec558 100644
> --- a/test/stress/fbtsafety/tst.strtok.d
> +++ b/test/stress/fbtsafety/tst.strtok.d
> @@ -1,6 +1,6 @@
>  /*
>   * Oracle Linux DTrace.
> - * Copyright (c) 2006, 2020, Oracle and/or its affiliates. All rights reserved.
> + * Copyright (c) 2006, 2025, Oracle and/or its affiliates. All rights reserved.
>   * Licensed under the Universal Permissive License v 1.0 as shown at
>   * http://oss.oracle.com/licenses/upl.
>   */
> @@ -17,7 +17,7 @@ fbt:::
>  fbt:::
>  /on/
>  {
> -	trace(strtok((char *)rand(), (char *)(rand() ^ vtimestamp)));
> +	trace(strtok((char *)rand(), (char *)(rand() ^ timestamp)));
>  }
>  
>  fbt:::entry
> diff --git a/test/stress/fbtsafety/tst.substr.d b/test/stress/fbtsafety/tst.substr.d
> index 8cd021176..ac02584ee 100644
> --- a/test/stress/fbtsafety/tst.substr.d
> +++ b/test/stress/fbtsafety/tst.substr.d
> @@ -1,6 +1,6 @@
>  /*
>   * Oracle Linux DTrace.
> - * Copyright (c) 2006, 2020, Oracle and/or its affiliates. All rights reserved.
> + * Copyright (c) 2006, 2025, Oracle and/or its affiliates. All rights reserved.
>   * Licensed under the Universal Permissive License v 1.0 as shown at
>   * http://oss.oracle.com/licenses/upl.
>   */
> @@ -17,13 +17,13 @@ fbt:::
>  fbt:::
>  /on/
>  {
> -	trace(substr((char *)rand(), rand() ^ vtimestamp));
> +	trace(substr((char *)rand(), rand() ^ timestamp));
>  }
>  
>  fbt:::
>  /on/
>  {
> -	trace(substr((char *)rand(), -rand() ^ vtimestamp));
> +	trace(substr((char *)rand(), -rand() ^ timestamp));
>  }
>  
>  tick-1sec
> diff --git a/test/unittest/variables/bvar/tst.vtimestamp.d b/test/unittest/variables/bvar/tst.vtimestamp.d
> index b72eb8a7f..7d92bf4cc 100644
> --- a/test/unittest/variables/bvar/tst.vtimestamp.d
> +++ b/test/unittest/variables/bvar/tst.vtimestamp.d
> @@ -4,7 +4,7 @@
>   * Licensed under the Universal Permissive License v 1.0 as shown at
>   * http://oss.oracle.com/licenses/upl.
>   */
> -/* @@xfail: dtv2 need vtimestamp support */
> +/* @@xfail: dtv2: need vtimestamp support */
>  
>  /*
>   * ASSERTION: The 'vtimestamp' variable can be accessed and is not -1.
> -- 
> 2.47.3
> 
> 
> _______________________________________________
> DTrace-devel mailing list
> DTrace-devel@oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/dtrace-devel

      reply	other threads:[~2025-10-08 16:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-07 22:55 [PATCH] test: Modify fbtsafety tests that use vtimestamp unnecessarily eugene.loh
2025-10-08 16:37 ` Kris Van Hees [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aOaTYrHmJky0rOAS@oracle.com \
    --to=kris.van.hees@oracle.com \
    --cc=dtrace-devel@oss.oracle.com \
    --cc=dtrace@lists.linux.dev \
    --cc=eugene.loh@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox