Re: [PATCH] test: Use copyinstr to copy string from user space

Kris Van Hees
2025-10-17T06:11:33Z

On Thu, Oct 16, 2025 at 10:21:13PM -0400, eugene.loh@oracle.com wrote:
> From: Eugene Loh <eugene.loh@oracle.com>
>
> Signed-off-by: Eugene Loh <eugene.loh@oracle.com>

Reviewed-by: Kris Van Hees <kris.van.hees@oracle.com>

> ---
> test/unittest/proc/tst.exec-execve.sh | 2 +-
> test/unittest/proc/tst.exec-execveat.sh | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/test/unittest/proc/tst.exec-execve.sh b/test/unittest/proc/tst.exec-execve.sh
> index d3f84e0d2..b70f0a6ea 100755
> --- a/test/unittest/proc/tst.exec-execve.sh
> +++ b/test/unittest/proc/tst.exec-execve.sh
> @@ -42,7 +42,7 @@ proc:::exec
> syscall::execve:entry
> /ppid == dtpid && execname == "parent.x"/
> {
> - printf("execve %s\n", stringof(arg0));
> + printf("execve %s\n", copyinstr(arg0));
> }' -c ./parent.x
> if [ $? -ne 0 ]; then
> echo ERROR
> diff --git a/test/unittest/proc/tst.exec-execveat.sh b/test/unittest/proc/tst.exec-execveat.sh
> index e4b9dfa5e..09a3d9338 100755
> --- a/test/unittest/proc/tst.exec-execveat.sh
> +++ b/test/unittest/proc/tst.exec-execveat.sh
> @@ -44,7 +44,7 @@ proc:::exec
> syscall::execveat:entry
> /ppid == dtpid && execname == "parent.x"/
> {
> - printf("execveat %s\n", stringof(arg1));
> + printf("execveat %s\n", copyinstr(arg1));
> }' -c ./parent.x
> if [ $? -ne 0 ]; then
> echo ERROR
> --
> 2.47.3
>