public inbox for dtrace@lists.linux.dev
 help / color / mirror / Atom feed
From: Kris Van Hees <kris.van.hees@oracle.com>
To: eugene.loh@oracle.com
Cc: dtrace@lists.linux.dev, dtrace-devel@oss.oracle.com
Subject: Re: [PATCH] Add llm directory to installed doc directory
Date: Mon, 26 Jan 2026 15:05:57 -0500	[thread overview]
Message-ID: <aXfJJVU58IaTbOQv@oracle.com> (raw)
In-Reply-To: <20260126193920.16930-1-eugene.loh@oracle.com>

On Mon, Jan 26, 2026 at 02:39:20PM -0500, eugene.loh@oracle.com wrote:
> From: Eugene Loh <eugene.loh@oracle.com>
> 
> Signed-off-by: Eugene Loh <eugene.loh@oracle.com>

Reviewed-by: Kris Van Hees <kris.van.hees@oracle.com>

... although it seems to me that we should be doing this (and the install of
the other doc files) from a doc/Build file rather than from the toplevel Build
file.

> ---
>  Build | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Build b/Build
> index 434f8ad92..cb8db08a3 100644
> --- a/Build
> +++ b/Build
> @@ -10,7 +10,8 @@ install::
>  	mkdir -p $(INSTDOCDIR)/userguide/reference
>  	mkdir -p $(INSTDOCDIR)/examples/
>  	mkdir -p $(INSTDOCDIR)/examples/language_features
> -	$(call describe-install-target,$(INSTDOCDIR),README INCOMPATIBILITIES NEWS tutorial userguide examples)
> +	mkdir -p $(INSTDOCDIR)/llm
> +	$(call describe-install-target,$(INSTDOCDIR),README INCOMPATIBILITIES NEWS tutorial userguide examples llm)
>  	install -m 644 README INCOMPATIBILITIES NEWS $(INSTDOCDIR)
>  	install -m 644 doc/tutorial/*.md $(INSTDOCDIR)/tutorial
>  	install -m 644 doc/userguide/index.md $(INSTDOCDIR)/userguide
> @@ -20,6 +21,7 @@ install::
>  	install -m 755 examples/*.d $(INSTDOCDIR)/examples
>  	install -m 644 examples/README.md $(INSTDOCDIR)/examples
>  	install -m 755 examples/language_features/* $(INSTDOCDIR)/examples/language_features
> +	install -m 644 llm/* $(INSTDOCDIR)/llm
>  
>  
>  install-test::
> -- 
> 2.47.3
> 

      reply	other threads:[~2026-01-26 20:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-26 19:39 [PATCH] Add llm directory to installed doc directory eugene.loh
2026-01-26 20:05 ` Kris Van Hees [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aXfJJVU58IaTbOQv@oracle.com \
    --to=kris.van.hees@oracle.com \
    --cc=dtrace-devel@oss.oracle.com \
    --cc=dtrace@lists.linux.dev \
    --cc=eugene.loh@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox