From: Kris Van Hees <kris.van.hees@oracle.com>
To: Eugene Loh <eugene.loh@oracle.com>
Cc: Kris Van Hees <kris.van.hees@oracle.com>,
dtrace@lists.linux.dev, dtrace-devel@oss.oracle.com
Subject: Re: [DTrace-devel] [PATCH] configure: add support for --disable-option-checking
Date: Wed, 18 Feb 2026 00:07:32 -0500 [thread overview]
Message-ID: <aZVJFMHoDVtOxQiz@oracle.com> (raw)
In-Reply-To: <77a78d0d-36c8-5540-6635-4ac8bbd72f60@oracle.com>
On Tue, Feb 17, 2026 at 04:03:38PM -0500, Eugene Loh wrote:
> Looks fine except again this should probably be documented when "--help" is
> used.
Sure.
> Also, I don't know if you agree on moving those enable-dependency options.
> If so, I guess this patch won't apply cleanly?
I think it is better not to move them.
> On 2/17/26 12:01, Kris Van Hees via DTrace-devel wrote:
>
> > Signed-off-by: Kris Van Hees <kris.van.hees@oracle.com>
> > ---
> > configure | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/configure b/configure
> > index fadac05e..f10c7f4d 100755
> > --- a/configure
> > +++ b/configure
> > @@ -123,6 +123,11 @@ rm -rf build/.config.new build/.config-vars.mk.new
> > echo 'override CONFIGURED_VARS=' > build/.config-vars.mk.new
> > trap 'rm -rf build/.config.new build/.config-vars.mk.new' ERR
> > +# Should we report unknown --disable/enable/with/without-* options?
> > +if echo " $@ " | grep ' --disable-option-checking ' &>/dev/null; then
> > + no_check_opts=t
> > +fi
> > +
> > for option in "$@"; do
> > case "$option" in
> > --help) help; exit 1;;
> > @@ -174,6 +179,11 @@ for option in "$@"; do
> > HAVE_BPFMASM=*) write_config_var BPFMASM "$option";;
> > --disable-dependency-tracking) write_make_var WITHOUT_DEPENDENCIES "y";;
> > --enable-dependency-tracking) write_make_var WITHOUT_DEPENDENCIES "n";;
> > + --disable-*|--enable-*|--with-*|--without-*)
> > + if [[ -z $no_check_opts ]]; then
> > + echo "Unknown option $option" >&2
> > + exit 1
> > + fi;;
> > *) echo "Unknown option $option" >&2
> > exit 1;;
> > esac
prev parent reply other threads:[~2026-02-18 5:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-17 17:01 [PATCH] configure: add support for --disable-option-checking Kris Van Hees
2026-02-17 21:03 ` [DTrace-devel] " Eugene Loh
2026-02-18 5:07 ` Kris Van Hees [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZVJFMHoDVtOxQiz@oracle.com \
--to=kris.van.hees@oracle.com \
--cc=dtrace-devel@oss.oracle.com \
--cc=dtrace@lists.linux.dev \
--cc=eugene.loh@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox