public inbox for dtrace@lists.linux.dev
 help / color / mirror / Atom feed
* [PATCH] configure: add support for --disable-option-checking
@ 2026-02-17 17:01 Kris Van Hees
  2026-02-17 21:03 ` [DTrace-devel] " Eugene Loh
  0 siblings, 1 reply; 3+ messages in thread
From: Kris Van Hees @ 2026-02-17 17:01 UTC (permalink / raw)
  To: dtrace, dtrace-devel

Signed-off-by: Kris Van Hees <kris.van.hees@oracle.com>
---
 configure | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/configure b/configure
index fadac05e..f10c7f4d 100755
--- a/configure
+++ b/configure
@@ -123,6 +123,11 @@ rm -rf build/.config.new build/.config-vars.mk.new
 echo 'override CONFIGURED_VARS=' > build/.config-vars.mk.new
 trap 'rm -rf build/.config.new build/.config-vars.mk.new' ERR
 
+# Should we report unknown --disable/enable/with/without-* options?
+if echo " $@ " | grep ' --disable-option-checking ' &>/dev/null; then
+   no_check_opts=t
+fi
+
 for option in "$@"; do
     case "$option" in
         --help) help; exit 1;;
@@ -174,6 +179,11 @@ for option in "$@"; do
         HAVE_BPFMASM=*) write_config_var BPFMASM "$option";;
         --disable-dependency-tracking) write_make_var WITHOUT_DEPENDENCIES "y";;
         --enable-dependency-tracking) write_make_var WITHOUT_DEPENDENCIES "n";;
+        --disable-*|--enable-*|--with-*|--without-*)
+           if [[ -z $no_check_opts ]]; then
+              echo "Unknown option $option" >&2
+              exit 1
+           fi;;
         *) echo "Unknown option $option" >&2
            exit 1;;
     esac
-- 
2.51.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [DTrace-devel] [PATCH] configure: add support for --disable-option-checking
  2026-02-17 17:01 [PATCH] configure: add support for --disable-option-checking Kris Van Hees
@ 2026-02-17 21:03 ` Eugene Loh
  2026-02-18  5:07   ` Kris Van Hees
  0 siblings, 1 reply; 3+ messages in thread
From: Eugene Loh @ 2026-02-17 21:03 UTC (permalink / raw)
  To: Kris Van Hees, dtrace, dtrace-devel

Looks fine except again this should probably be documented when "--help" 
is used.

Also, I don't know if you agree on moving those enable-dependency 
options.  If so, I guess this patch won't apply cleanly?

On 2/17/26 12:01, Kris Van Hees via DTrace-devel wrote:

> Signed-off-by: Kris Van Hees <kris.van.hees@oracle.com>
> ---
>   configure | 10 ++++++++++
>   1 file changed, 10 insertions(+)
>
> diff --git a/configure b/configure
> index fadac05e..f10c7f4d 100755
> --- a/configure
> +++ b/configure
> @@ -123,6 +123,11 @@ rm -rf build/.config.new build/.config-vars.mk.new
>   echo 'override CONFIGURED_VARS=' > build/.config-vars.mk.new
>   trap 'rm -rf build/.config.new build/.config-vars.mk.new' ERR
>   
> +# Should we report unknown --disable/enable/with/without-* options?
> +if echo " $@ " | grep ' --disable-option-checking ' &>/dev/null; then
> +   no_check_opts=t
> +fi
> +
>   for option in "$@"; do
>       case "$option" in
>           --help) help; exit 1;;
> @@ -174,6 +179,11 @@ for option in "$@"; do
>           HAVE_BPFMASM=*) write_config_var BPFMASM "$option";;
>           --disable-dependency-tracking) write_make_var WITHOUT_DEPENDENCIES "y";;
>           --enable-dependency-tracking) write_make_var WITHOUT_DEPENDENCIES "n";;
> +        --disable-*|--enable-*|--with-*|--without-*)
> +           if [[ -z $no_check_opts ]]; then
> +              echo "Unknown option $option" >&2
> +              exit 1
> +           fi;;
>           *) echo "Unknown option $option" >&2
>              exit 1;;
>       esac

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [DTrace-devel] [PATCH] configure: add support for --disable-option-checking
  2026-02-17 21:03 ` [DTrace-devel] " Eugene Loh
@ 2026-02-18  5:07   ` Kris Van Hees
  0 siblings, 0 replies; 3+ messages in thread
From: Kris Van Hees @ 2026-02-18  5:07 UTC (permalink / raw)
  To: Eugene Loh; +Cc: Kris Van Hees, dtrace, dtrace-devel

On Tue, Feb 17, 2026 at 04:03:38PM -0500, Eugene Loh wrote:
> Looks fine except again this should probably be documented when "--help" is
> used.

Sure.

> Also, I don't know if you agree on moving those enable-dependency options. 
> If so, I guess this patch won't apply cleanly?

I think it is better not to move them.

> On 2/17/26 12:01, Kris Van Hees via DTrace-devel wrote:
> 
> > Signed-off-by: Kris Van Hees <kris.van.hees@oracle.com>
> > ---
> >   configure | 10 ++++++++++
> >   1 file changed, 10 insertions(+)
> > 
> > diff --git a/configure b/configure
> > index fadac05e..f10c7f4d 100755
> > --- a/configure
> > +++ b/configure
> > @@ -123,6 +123,11 @@ rm -rf build/.config.new build/.config-vars.mk.new
> >   echo 'override CONFIGURED_VARS=' > build/.config-vars.mk.new
> >   trap 'rm -rf build/.config.new build/.config-vars.mk.new' ERR
> > +# Should we report unknown --disable/enable/with/without-* options?
> > +if echo " $@ " | grep ' --disable-option-checking ' &>/dev/null; then
> > +   no_check_opts=t
> > +fi
> > +
> >   for option in "$@"; do
> >       case "$option" in
> >           --help) help; exit 1;;
> > @@ -174,6 +179,11 @@ for option in "$@"; do
> >           HAVE_BPFMASM=*) write_config_var BPFMASM "$option";;
> >           --disable-dependency-tracking) write_make_var WITHOUT_DEPENDENCIES "y";;
> >           --enable-dependency-tracking) write_make_var WITHOUT_DEPENDENCIES "n";;
> > +        --disable-*|--enable-*|--with-*|--without-*)
> > +           if [[ -z $no_check_opts ]]; then
> > +              echo "Unknown option $option" >&2
> > +              exit 1
> > +           fi;;
> >           *) echo "Unknown option $option" >&2
> >              exit 1;;
> >       esac

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-02-18  5:07 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-17 17:01 [PATCH] configure: add support for --disable-option-checking Kris Van Hees
2026-02-17 21:03 ` [DTrace-devel] " Eugene Loh
2026-02-18  5:07   ` Kris Van Hees

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox