From: Kris Van Hees <kris.van.hees@oracle.com>
To: dtrace@lists.linux.dev, dtrace-devel@oss.oracle.com
Subject: [PATCH 08/20] libdtrace: grow module address ranges geometrically
Date: Fri, 30 Oct 2026 19:36:41 +0000 [thread overview]
Message-ID: <aa68020442985d905ffea22f1039e4eb@oracle.com> (raw)
---
libdtrace/dt_impl.h | 2 ++
libdtrace/dt_module.c | 21 +++++++++++++++------
2 files changed, 17 insertions(+), 6 deletions(-)
diff --git a/libdtrace/dt_impl.h b/libdtrace/dt_impl.h
index fcdac855..f89ce2bc 100644
--- a/libdtrace/dt_impl.h
+++ b/libdtrace/dt_impl.h
@@ -149,8 +149,10 @@ typedef struct dt_module {
dtrace_addr_range_t *dm_text_addrs; /* text addresses, sorted */
size_t dm_text_addrs_size; /* number of entries */
+ size_t dm_text_addrs_cap; /* allocated entries */
dtrace_addr_range_t *dm_data_addrs; /* data/BSS addresses, sorted */
size_t dm_data_addrs_size; /* number of entries */
+ size_t dm_data_addrs_cap; /* allocated entries */
dt_idhash_t *dm_extern; /* external symbol definitions */
diff --git a/libdtrace/dt_module.c b/libdtrace/dt_module.c
index 6868268e..7cc68968 100644
--- a/libdtrace/dt_module.c
+++ b/libdtrace/dt_module.c
@@ -1141,22 +1141,31 @@ dtrace_addr_range_grow(dt_module_t *dmp, int is_text)
dtrace_addr_range_t **range;
dtrace_addr_range_t *new_range;
dtrace_addr_range_t *final_range;
- size_t *size;
+ size_t *size, *capacity;
if (is_text) {
range = &dmp->dm_text_addrs;
size = &dmp->dm_text_addrs_size;
+ capacity = &dmp->dm_text_addrs_cap;
} else {
range = &dmp->dm_data_addrs;
size = &dmp->dm_data_addrs_size;
+ capacity = &dmp->dm_data_addrs_cap;
}
- new_range = realloc(*range, sizeof(struct dtrace_addr_range) *
- (*size+1));
- if (new_range == NULL)
- return NULL;
+ if (*size == *capacity) {
+ size_t cap = *capacity == 0 ? 4 : *capacity * 2;
- *range = new_range;
+ if (cap < *capacity || cap > SIZE_MAX / sizeof(**range))
+ return NULL;
+ new_range = realloc(*range, sizeof(**range) * cap);
+ if (new_range == NULL)
+ return NULL;
+
+ *range = new_range;
+ *capacity = cap;
+ }
+ new_range = *range;
final_range = new_range + (*size);
final_range->dar_va = 0;
final_range->dar_size = 0;
--
2.52.0
next reply other threads:[~2026-10-30 19:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-30 19:36 Kris Van Hees [this message]
2026-11-06 12:54 ` [PATCH 08/20] libdtrace: grow module address ranges geometrically Nick Alcock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa68020442985d905ffea22f1039e4eb@oracle.com \
--to=kris.van.hees@oracle.com \
--cc=dtrace-devel@oss.oracle.com \
--cc=dtrace@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox