public inbox for dtrace@lists.linux.dev
 help / color / mirror / Atom feed
From: Eugene Loh <eugene.loh@oracle.com>
To: Kris Van Hees <kris.van.hees@oracle.com>,
	dtrace@lists.linux.dev, dtrace-devel@oss.oracle.com
Subject: Re: [DTrace-devel] [PATCH] configure: add support for --(disable|enable)-dependency-tracking
Date: Tue, 17 Feb 2026 15:44:05 -0500	[thread overview]
Message-ID: <abf2b87f-940f-1444-73d2-30d5b64a5102@oracle.com> (raw)
In-Reply-To: <DS0PR10MB7522C462F5DF76BD9E145DEEC26DA@DS0PR10MB7522.namprd10.prod.outlook.com>

On 2/17/26 11:35, Kris Van Hees via DTrace-devel wrote:

> Signed-off-by: Kris Van Hees <kris.van.hees@oracle.com>
> ---
>   Makefunctions | 2 ++
>   configure     | 2 ++
>   2 files changed, 4 insertions(+)
>
> diff --git a/Makefunctions b/Makefunctions
> index 15836dc3..1f308967 100644
> --- a/Makefunctions
> +++ b/Makefunctions
> @@ -52,7 +52,9 @@ endef
>   # Rule to build a C source file.
>   # Syntax: $(call cc-template,primary,filename-without-dir,optional flags)
>   
> +ifndef WITHOUT_DEPENDENCIES
>   cc-dependencies = -MP -MMD -MF $(obj-name).deps -MT $(obj-name)
> +endif
>   
>   define cc-template
>   $(obj-name): $(src-name) $(foreach dep,$($(1)_SRCDEPS),$(call src-name,$(1),$(dep))) $(foreach prov,$($(1)_PROV),$(call hdr-name,$(1),$(prov))) $(CONFIG_H)
> diff --git a/configure b/configure
> index 04c28369..fadac05e 100755
> --- a/configure
> +++ b/configure
> @@ -172,6 +172,8 @@ for option in "$@"; do
>           HAVE_VALGRIND=*) write_config_var VALGRIND "$option";;
>           HAVE_BPFV3=*) write_config_var BPFV3 "$option";;
>           HAVE_BPFMASM=*) write_config_var BPFMASM "$option";;
> +        --disable-dependency-tracking) write_make_var WITHOUT_DEPENDENCIES "y";;
> +        --enable-dependency-tracking) write_make_var WITHOUT_DEPENDENCIES "n";;

Maybe add these earlier/higher?  Where the other write_make_var settings 
are?

Also, should these options be documented?  Like in the file's help()?

(Come to think of it, how about --with-libctf and --with-libfuse3? 
Should they also appear in --help?)

>           *) echo "Unknown option $option" >&2
>              exit 1;;
>       esac

  reply	other threads:[~2026-02-17 20:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-17 16:35 [PATCH] configure: add support for --(disable|enable)-dependency-tracking Kris Van Hees
2026-02-17 20:44 ` Eugene Loh [this message]
2026-02-18  5:07   ` [DTrace-devel] " Kris Van Hees
2026-02-18  5:38     ` Kris Van Hees

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abf2b87f-940f-1444-73d2-30d5b64a5102@oracle.com \
    --to=eugene.loh@oracle.com \
    --cc=dtrace-devel@oss.oracle.com \
    --cc=dtrace@lists.linux.dev \
    --cc=kris.van.hees@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox