dtrace.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/5] test: fix typos and clarify assertions
@ 2025-08-13 15:57 Kris Van Hees
  2025-08-13 19:58 ` [DTrace-devel] " Eugene Loh
  0 siblings, 1 reply; 2+ messages in thread
From: Kris Van Hees @ 2025-08-13 15:57 UTC (permalink / raw)
  To: dtrace, dtrace-devel

Signed-off-by: Kris Van Hees <kris.van.hees@oracle.com>
---
 test/unittest/actions/trace/tst.array-char-multi-nul.d     | 2 +-
 test/unittest/actions/trace/tst.array-char-str-multi-nul.d | 2 +-
 test/unittest/actions/trace/tst.array-char-str-no-nul.d    | 4 ++--
 test/unittest/actions/trace/tst.array-char-str.d           | 2 +-
 test/unittest/actions/trace/tst.array-char-unprintable.d   | 2 +-
 5 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/test/unittest/actions/trace/tst.array-char-multi-nul.d b/test/unittest/actions/trace/tst.array-char-multi-nul.d
index ae6370a4a..bd91498f3 100644
--- a/test/unittest/actions/trace/tst.array-char-multi-nul.d
+++ b/test/unittest/actions/trace/tst.array-char-multi-nul.d
@@ -7,7 +7,7 @@
 
 /*
  * ASSERTION: The trace() action prints a char-array of printable characters
- *	      with multiple 0-bytes in its content.
+ *	      with multiple 0-bytes in its content as raw bytes.
  *
  * SECTION: Actions and Subroutines/trace()
  */
diff --git a/test/unittest/actions/trace/tst.array-char-str-multi-nul.d b/test/unittest/actions/trace/tst.array-char-str-multi-nul.d
index 4734e619b..ba0435db8 100644
--- a/test/unittest/actions/trace/tst.array-char-str-multi-nul.d
+++ b/test/unittest/actions/trace/tst.array-char-str-multi-nul.d
@@ -7,7 +7,7 @@
 
 /*
  * ASSERTION: The trace() action prints a char-array of printable characters
- *	      followed y by multiple 0-bytes correctly.
+ *	      followed by multiple 0-bytes correctly as a string.
  *
  * SECTION: Actions and Subroutines/trace()
  */
diff --git a/test/unittest/actions/trace/tst.array-char-str-no-nul.d b/test/unittest/actions/trace/tst.array-char-str-no-nul.d
index c9acc4e73..48633a6cb 100644
--- a/test/unittest/actions/trace/tst.array-char-str-no-nul.d
+++ b/test/unittest/actions/trace/tst.array-char-str-no-nul.d
@@ -6,8 +6,8 @@
  */
 
 /*
- * ASSERTION: The trace() action prints a char-aarray of printable characters
- *	      (not terminated) correctly.
+ * ASSERTION: The trace() action prints a char-array of printable characters
+ *	      (not terminated) correctly as a string.
  *
  * SECTION: Actions and Subroutines/trace()
  */
diff --git a/test/unittest/actions/trace/tst.array-char-str.d b/test/unittest/actions/trace/tst.array-char-str.d
index 465721b04..b61de776c 100644
--- a/test/unittest/actions/trace/tst.array-char-str.d
+++ b/test/unittest/actions/trace/tst.array-char-str.d
@@ -7,7 +7,7 @@
 
 /*
  * ASSERTION: The trace() action prints a char-array of printable characters
- *	      (terminated) correctly.
+ *	      (terminated) correctly as a string.
  *
  * SECTION: Actions and Subroutines/trace()
  */
diff --git a/test/unittest/actions/trace/tst.array-char-unprintable.d b/test/unittest/actions/trace/tst.array-char-unprintable.d
index 2fa5a1066..5b2525c35 100644
--- a/test/unittest/actions/trace/tst.array-char-unprintable.d
+++ b/test/unittest/actions/trace/tst.array-char-unprintable.d
@@ -7,7 +7,7 @@
 
 /*
  * ASSERTION: The trace() action prints a char-array with a non-printable
- *	      character correctly.
+ *	      character correctly as raw bytes.
  *
  * SECTION: Actions and Subroutines/trace()
  */
-- 
2.45.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [DTrace-devel] [PATCH 1/5] test: fix typos and clarify assertions
  2025-08-13 15:57 [PATCH 1/5] test: fix typos and clarify assertions Kris Van Hees
@ 2025-08-13 19:58 ` Eugene Loh
  0 siblings, 0 replies; 2+ messages in thread
From: Eugene Loh @ 2025-08-13 19:58 UTC (permalink / raw)
  To: Kris Van Hees, dtrace, dtrace-devel

Reviewed-by: Eugene Loh <eugene.loh@oracle.com>

On 8/13/25 11:57, Kris Van Hees via DTrace-devel wrote:
> Signed-off-by: Kris Van Hees <kris.van.hees@oracle.com>
> ---
>   test/unittest/actions/trace/tst.array-char-multi-nul.d     | 2 +-
>   test/unittest/actions/trace/tst.array-char-str-multi-nul.d | 2 +-
>   test/unittest/actions/trace/tst.array-char-str-no-nul.d    | 4 ++--
>   test/unittest/actions/trace/tst.array-char-str.d           | 2 +-
>   test/unittest/actions/trace/tst.array-char-unprintable.d   | 2 +-
>   5 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/test/unittest/actions/trace/tst.array-char-multi-nul.d b/test/unittest/actions/trace/tst.array-char-multi-nul.d
> index ae6370a4a..bd91498f3 100644
> --- a/test/unittest/actions/trace/tst.array-char-multi-nul.d
> +++ b/test/unittest/actions/trace/tst.array-char-multi-nul.d
> @@ -7,7 +7,7 @@
>   
>   /*
>    * ASSERTION: The trace() action prints a char-array of printable characters
> - *	      with multiple 0-bytes in its content.
> + *	      with multiple 0-bytes in its content as raw bytes.
>    *
>    * SECTION: Actions and Subroutines/trace()
>    */
> diff --git a/test/unittest/actions/trace/tst.array-char-str-multi-nul.d b/test/unittest/actions/trace/tst.array-char-str-multi-nul.d
> index 4734e619b..ba0435db8 100644
> --- a/test/unittest/actions/trace/tst.array-char-str-multi-nul.d
> +++ b/test/unittest/actions/trace/tst.array-char-str-multi-nul.d
> @@ -7,7 +7,7 @@
>   
>   /*
>    * ASSERTION: The trace() action prints a char-array of printable characters
> - *	      followed y by multiple 0-bytes correctly.
> + *	      followed by multiple 0-bytes correctly as a string.
>    *
>    * SECTION: Actions and Subroutines/trace()
>    */
> diff --git a/test/unittest/actions/trace/tst.array-char-str-no-nul.d b/test/unittest/actions/trace/tst.array-char-str-no-nul.d
> index c9acc4e73..48633a6cb 100644
> --- a/test/unittest/actions/trace/tst.array-char-str-no-nul.d
> +++ b/test/unittest/actions/trace/tst.array-char-str-no-nul.d
> @@ -6,8 +6,8 @@
>    */
>   
>   /*
> - * ASSERTION: The trace() action prints a char-aarray of printable characters
> - *	      (not terminated) correctly.
> + * ASSERTION: The trace() action prints a char-array of printable characters
> + *	      (not terminated) correctly as a string.
>    *
>    * SECTION: Actions and Subroutines/trace()
>    */
> diff --git a/test/unittest/actions/trace/tst.array-char-str.d b/test/unittest/actions/trace/tst.array-char-str.d
> index 465721b04..b61de776c 100644
> --- a/test/unittest/actions/trace/tst.array-char-str.d
> +++ b/test/unittest/actions/trace/tst.array-char-str.d
> @@ -7,7 +7,7 @@
>   
>   /*
>    * ASSERTION: The trace() action prints a char-array of printable characters
> - *	      (terminated) correctly.
> + *	      (terminated) correctly as a string.
>    *
>    * SECTION: Actions and Subroutines/trace()
>    */
> diff --git a/test/unittest/actions/trace/tst.array-char-unprintable.d b/test/unittest/actions/trace/tst.array-char-unprintable.d
> index 2fa5a1066..5b2525c35 100644
> --- a/test/unittest/actions/trace/tst.array-char-unprintable.d
> +++ b/test/unittest/actions/trace/tst.array-char-unprintable.d
> @@ -7,7 +7,7 @@
>   
>   /*
>    * ASSERTION: The trace() action prints a char-array with a non-printable
> - *	      character correctly.
> + *	      character correctly as raw bytes.
>    *
>    * SECTION: Actions and Subroutines/trace()
>    */

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-08-13 19:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-13 15:57 [PATCH 1/5] test: fix typos and clarify assertions Kris Van Hees
2025-08-13 19:58 ` [DTrace-devel] " Eugene Loh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).