Re: [PATCH 13/22] Eliminate unused args to dt_spec_buf_add_data()

Kris Van Hees
2024-09-14T17:06:56Z

On Thu, Aug 29, 2024 at 01:22:10AM -0400, eugene.loh@oracle.com wrote:
> From: Eugene Loh <eugene.loh@oracle.com>
>
> Signed-off-by: Eugene Loh <eugene.loh@oracle.com>

Reviewed-by: Kris Van Hees <kris.van.hees@oracle.com>

> ---
> libdtrace/dt_consume.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/libdtrace/dt_consume.c b/libdtrace/dt_consume.c
> index 6aa9812e..51eb6c80 100644
> --- a/libdtrace/dt_consume.c
> +++ b/libdtrace/dt_consume.c
> @@ -2060,9 +2060,7 @@ oom:
>
> static dt_spec_buf_data_t *
> dt_spec_buf_add_data(dtrace_hdl_t *dtp, dt_spec_buf_t *dtsb,
> - dtrace_epid_t epid, unsigned int cpu,
> - dtrace_datadesc_t *datadesc, char *data,
> - uint32_t size)
> + unsigned int cpu, char *data, uint32_t size)
> {
> dt_spec_buf_data_t *dsbd;
>
> @@ -2265,8 +2263,7 @@ dt_consume_one_probe(dtrace_hdl_t *dtp, FILE *fp, char *data, uint32_t size,
> }
> }
>
> - if (dt_spec_buf_add_data(dtp, dtsb, epid, pdat->dtpda_cpu, epd,
> - data, size) == NULL)
> + if (dt_spec_buf_add_data(dtp, dtsb, pdat->dtpda_cpu, data, size) == NULL)
> dtp->dt_specdrops++;
>
> return DTRACE_WORKSTATUS_OKAY;
> --
> 2.43.5
>