Re: [PATCH 17/22] test: Tweak spec sizes to bracket size jumps more narrowly

Kris Van Hees
2024-09-14T18:08:06Z

[-- Attachment #1: Type: text/plain, Size: 1737 bytes --]

This test gives me faqilures.

runtest.log in attachment

On Thu, Aug 29, 2024 at 01:22:14AM -0400, eugene.loh@oracle.com wrote:
> From: Eugene Loh <eugene.loh@oracle.com>
>
> Signed-off-by: Eugene Loh <eugene.loh@oracle.com>
> ---
> .../speculation/tst.SpecSizeVariations.r | 22 -------------------
> .../speculation/tst.SpecSizeVariations.sh | 2 +-
> 2 files changed, 1 insertion(+), 23 deletions(-)
>
> diff --git a/test/unittest/speculation/tst.SpecSizeVariations.r b/test/unittest/speculation/tst.SpecSizeVariations.r
> index 51f0596c..2748b307 100644
> --- a/test/unittest/speculation/tst.SpecSizeVariations.r
> +++ b/test/unittest/speculation/tst.SpecSizeVariations.r
> @@ -11,26 +11,6 @@ Speculative buffer ID: 1
> 123456706
> counts: 1 1
>
> -Speculative buffer ID: 1
> -123456700
> -123456701
> -123456702
> -123456703
> -123456704
> -123456705
> -123456706
> -counts: 1 1
> -
> -Speculative buffer ID: 1
> -123456700
> -123456701
> -123456702
> -123456703
> -123456704
> -123456705
> -123456706
> -counts: 2 1
> -
> Speculative buffer ID: 1
> 123456700
> 123456701
> @@ -64,5 +44,3 @@ counts: 2 1
> dtrace: 2 speculative drops
> dtrace: 1 speculative drop
> dtrace: 1 speculative drop
> -dtrace: 1 speculative drop
> -dtrace: 1 speculative drop
> diff --git a/test/unittest/speculation/tst.SpecSizeVariations.sh b/test/unittest/speculation/tst.SpecSizeVariations.sh
> index 75e527d9..79995b59 100755
> --- a/test/unittest/speculation/tst.SpecSizeVariations.sh
> +++ b/test/unittest/speculation/tst.SpecSizeVariations.sh
> @@ -9,7 +9,7 @@
>
> dtrace=$1
>
> -for x in 63 64 79 80 143 144; do
> +for x in 71 72 159 160; do
> $dtrace $dt_flags -xspecsize=$x -qn '
> BEGIN
> {
> --
> 2.43.5
>

[-- Attachment #2: runtest.log --]
[-- Type: text/plain, Size: 2033 bytes --]

dtrace: Oracle D 2.0
This is DTrace 2.0.1
dtrace(1) version-control ID: 76d327b2d33c377041b8f1b3dbd67de7f2cc7b65
libdtrace version-control ID: 76d327b2d33c377041b8f1b3dbd67de7f2cc7b65
Linux kvh-deb-bpf3 6.8.8 #1 SMP PREEMPT_DYNAMIC Mon Apr 29 14:26:32 EDT 2024 x86_64 GNU/Linux
testsuite version-control ID: 76d327b2d33c377041b8f1b3dbd67de7f2cc7b65

test/unittest/speculation/tst.SpecSizeVariations.sh: Running timeout --signal=TERM 41 test/unittest/speculation/tst.SpecSizeVariations.sh /scratch/dtrace-bpf-user/build/dtrace
FAIL: expected results differ.
Speculative buffer ID: 1
123456700
123456701
123456702
123456703
123456704
123456705
123456706
counts: 1 1

Speculative buffer ID: 1
123456700
123456701
123456702
123456703
123456704
123456705
123456706
counts: 1 1

Speculative buffer ID: 1
123456700
123456701
123456702
123456703
123456704
123456705
123456706
123456800
123456801
123456802
123456803
123456804
123456805
123456806
123456807
123456808
counts: 2 1

Speculative buffer ID: 1
123456700
123456701
123456702
123456703
123456704
123456705
123456706
123456800
123456801
123456802
123456803
123456804
123456805
123456806
123456807
123456808
counts: 2 1

-- @@stderr --
dtrace: 1 speculative drop
dtrace: 1 speculative drop
Diff against expected:
--- test/unittest/speculation/tst.SpecSizeVariations.r 2024-09-14 14:04:10.560046706 -0400
+++ /tmp/runtest.27272/test.out 2024-09-14 14:06:03.926307171 -0400
@@ -1,5 +1,12 @@
Speculative buffer ID: 1
-counts: 0 1
+123456700
+123456701
+123456702
+123456703
+123456704
+123456705
+123456706
+counts: 1 1

Speculative buffer ID: 1
123456700
@@ -19,6 +26,15 @@
123456704
123456705
123456706
+123456800
+123456801
+123456802
+123456803
+123456804
+123456805
+123456806
+123456807
+123456808
counts: 2 1

Speculative buffer ID: 1
@@ -41,6 +57,5 @@
counts: 2 1

-- @@stderr --
-dtrace: 2 speculative drops
dtrace: 1 speculative drop
dtrace: 1 speculative drop
Cleaning took 0.022518012 (0 kprobes, 0 uprobes)

1 cases (0 PASS, 1 FAIL, 0 XPASS, 0 XFAIL, 0 SKIP)