Re: [PATCH 22/22] test: Update tst.newprobes.sh xfail message

Kris Van Hees
2024-09-14T18:45:23Z

On Thu, Aug 29, 2024 at 01:22:19AM -0400, eugene.loh@oracle.com wrote:
> From: Eugene Loh <eugene.loh@oracle.com>
>
> Signed-off-by: Eugene Loh <eugene.loh@oracle.com>
> ---
> test/unittest/pid/tst.newprobes.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/unittest/pid/tst.newprobes.sh b/test/unittest/pid/tst.newprobes.sh
> index a4944688..1a88c3a8 100755
> --- a/test/unittest/pid/tst.newprobes.sh
> +++ b/test/unittest/pid/tst.newprobes.sh
> @@ -6,7 +6,7 @@
> # http://oss.oracle.com/licenses/upl.
> #
>
> -# @@xfail: not working yet
> +# @@xfail: we do not support wildcard pids for pid probes

I think it would be more accurate to say that 'dtrace' does not support
wildcards pids for pid probe. It is not our choice or lack of support in
our implementation - dtrace never did support it.

Updated it to be:

# @@xfail: dtrace does not support wildcard pids for pid probes

>
> if [ $# != 1 ]; then
> echo expected one argument: '<'dtrace-path'>'
> --
> 2.43.5
>