public inbox for dtrace@lists.linux.dev
 help / color / mirror / Atom feed
From: Eugene Loh <eugene.loh@oracle.com>
To: Nick Alcock <nick.alcock@oracle.com>
Cc: dtrace@lists.linux.dev, dtrace-devel@oss.oracle.com
Subject: Re: [PATCH 2/4] test: Skip trace() of a 1-byte struct
Date: Wed, 13 Aug 2025 16:20:42 -0400	[thread overview]
Message-ID: <d639842c-9e86-bcea-e490-912e1019c9de@oracle.com> (raw)
In-Reply-To: <871pq88hk1.fsf@esperi.org.uk>

This patch is rescinded in deference to another patch that simply 
changes the .r file to match the current output.

On 7/22/25 09:46, Nick Alcock wrote:
> On 25 Mar 2025, eugene loh outgrape:
>
>> From: Eugene Loh <eugene.loh@oracle.com>
>>
>> With commit 3a551bfd ("trace: fix char-array handling"), this test
>> started to FAIL.  Meanwhile, the behavior of trace() on a 1-byte
>> struct is poorly defined.  Users wishing clear semantics should use
>> print() or other actions.
> This makes trace() much, much less useful. I'd say NAK, if this means
> we're going to not come up with any useful behaviour. Why not define
> something, then use it?
>
> Nobody is going to say "look at the size of something and then do a
> print() rather than a trace() if it's too small". Even looking at this
> commit I'm not sure what "too small" is (one byte? four bytes?
> sizeof(int)? sizeof(long)? A cacheline? what?) so I don't see how our
> users can be expected to.

  reply	other threads:[~2025-08-13 20:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-25 22:25 [PATCH 1/4] Remove orphaned dtrace_recdesc_t component dtrd_uarg eugene.loh
2025-03-25 22:25 ` [PATCH 2/4] test: Skip trace() of a 1-byte struct eugene.loh
2025-07-22 13:46   ` Nick Alcock
2025-08-13 20:20     ` Eugene Loh [this message]
2025-03-25 22:25 ` [PATCH 3/4] test: Update some char-array results files eugene.loh
2025-07-22 13:51   ` Nick Alcock
2025-07-22 21:53     ` Eugene Loh
2025-03-25 22:25 ` [PATCH 4/4] Pad strings in the output buffer with NUL bytes after terminating byte eugene.loh
2025-07-22 14:05   ` Nick Alcock
2025-04-11 20:38 ` [PATCH 1/4] Remove orphaned dtrace_recdesc_t component dtrd_uarg Kris Van Hees

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d639842c-9e86-bcea-e490-912e1019c9de@oracle.com \
    --to=eugene.loh@oracle.com \
    --cc=dtrace-devel@oss.oracle.com \
    --cc=dtrace@lists.linux.dev \
    --cc=nick.alcock@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox