public inbox for dtrace@lists.linux.dev
 help / color / mirror / Atom feed
From: Eugene Loh <eugene.loh@oracle.com>
To: Kris Van Hees <kris.van.hees@oracle.com>,
	dtrace@lists.linux.dev, dtrace-devel@oss.oracle.com
Subject: Re: [PATCH v2] trace: print alloca pointers as actual pointer values
Date: Fri, 12 Sep 2025 20:36:19 -0400	[thread overview]
Message-ID: <e464c8fb-2f74-a3e8-4fa9-c9074c0e661a@oracle.com> (raw)
In-Reply-To: <SJ0PR10MB56726ADFB2A8CBF47D3B8C46C208A@SJ0PR10MB5672.namprd10.prod.outlook.com>

Similar comments to v1:

On 9/12/25 00:16, Kris Van Hees wrote:
> Because alloca pointers are stored internally as ofssets into the

Again, s/ofssets/offsets/.

> scratchmem area, they were printed as small integers.  They are
> now printed as actual pointer values into kernel space.

And again test failures.  This time, not with the new test, but as you 
say, "Ah, tehe joy of fixing one problem only to uncover another."  So 
this time:

         test/unittest/funcs/alloca/tst.alloca-funcs.d: FAIL: expected 
results differ.
             Diff against expected:
              a/b
             -8b11/b/b3a/b//baba
             +18446671313727729520b11/b/b3a/b//baba

Here, "8" has become "18446671313727729520".  So, need some .r change 
(and some .r.p magic and possibly .d tweak).

         test/unittest/funcs/alloca/tst.string-alloca.d: FAIL: expected 
results differ.
             Diff against expected:
             -abc
             +

Here, simply a bug?

  reply	other threads:[~2025-09-13  0:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-12  4:16 [PATCH v2] trace: print alloca pointers as actual pointer values Kris Van Hees
2025-09-13  0:36 ` Eugene Loh [this message]
2025-09-13  0:50   ` Kris Van Hees

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e464c8fb-2f74-a3e8-4fa9-c9074c0e661a@oracle.com \
    --to=eugene.loh@oracle.com \
    --cc=dtrace-devel@oss.oracle.com \
    --cc=dtrace@lists.linux.dev \
    --cc=kris.van.hees@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox