Re: [PATCH v2 1/4] dtrace: move get_member() to dt_cg.c

[Eugene Loh <eugene.loh@oracle.com>]

Reviewed-by: Eugene Loh <eugene.loh@oracle.com>

btw...

On 6/10/25 09:58, Alan Maguire wrote:
> diff --git a/libdtrace/dt_cg.c b/libdtrace/dt_cg.c
> @@ -1901,6 +1901,45 @@ dt_cg_ctf_offsetof(const char *structname, const char *membername,
> +/*
> + * Retrieve the value of a member in a given struct.
> + *
> + * Entry:
> + *      reg = TYPE *ptr
> + *
> + * Return:
> + *      %r0 = ptr->member
> + * Clobbers:
> + *      %r1 .. %r5
> + */

The dominant (but admittedly not consistent) style of this file is to 
indent with a tab.  E.g., "^ *\treg = ...".  Clearly, we have not 
established a consistent style.